Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature: expanded and custom task icons (Lucide + Font Awesome + emoji) #248

Merged
approver_agent merged 7 commits from feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons into dev 2026-09-26 09:02:08 -04:00
Conversation 1 Commits 7 Files Changed 33
+5108 -1023
dev_agent commented 2026-09-26 08:37:14 -04:00
Member
Copy Link
Copy Source

Feature e0855415 — Expanded and custom task icons (Lucide + Font Awesome + emoji).

Delivered via 5 independently reviewed task PRs merged into this feature branch:

  • #241 Core/API namespaced icon keys (lucide/fa/emoji) with legacy back-compat (head 430f8ab)
  • #242 Shared icon registry, curated Lucide + FA, namespaced resolver, drift test (head 14fe912)
  • #243 Admin PWA Lucide+FA+emoji icon picker (head 59ff392)
  • #245 Kids' panel renders the definition icon on the open quest card; sealed keeps star (head a5f5086)
  • #246 Docs: namespaced keys, picker, third-party attribution (head 1bddc9f)

Feature head 7eed8fd, base dev fb9907a. Integration checks at 7eed8fd: TZ=UTC uv run pytest -q = 2076 passed; cd admin && npm test = 268 passed; cd admin && npm run build ok; cd frontend && npm run build ok; node tools/icons/generate.mjs --check exit 0; worktree clean (deterministic builds). No CDN/runtime fetch; all five tasks carry exact-head review_agent APPROVED reviews.

Feature e0855415 — Expanded and custom task icons (Lucide + Font Awesome + emoji). Delivered via 5 independently reviewed task PRs merged into this feature branch: - #241 Core/API namespaced icon keys (lucide/fa/emoji) with legacy back-compat (head 430f8ab) - #242 Shared icon registry, curated Lucide + FA, namespaced resolver, drift test (head 14fe912) - #243 Admin PWA Lucide+FA+emoji icon picker (head 59ff392) - #245 Kids' panel renders the definition icon on the open quest card; sealed keeps star (head a5f5086) - #246 Docs: namespaced keys, picker, third-party attribution (head 1bddc9f) Feature head 7eed8fd, base dev fb9907a. Integration checks at 7eed8fd: TZ=UTC uv run pytest -q = 2076 passed; cd admin && npm test = 268 passed; cd admin && npm run build ok; cd frontend && npm run build ok; node tools/icons/generate.mjs --check exit 0; worktree clean (deterministic builds). No CDN/runtime fetch; all five tasks carry exact-head review_agent APPROVED reviews.
dev_agent added 5 commits 2026-09-26 08:37:14 -04:00
Core/API: namespaced icon keys (lucide/fa/emoji) with legacy back-compat (#241) 60d1594136
Shared icon registry (curated Lucide + Font Awesome, namespaced resolver) (#242) a12451b58c
Admin PWA: Lucide + Font Awesome + emoji icon picker (#243) a93f91d4af
Kids' panel: render the definition icon on the open quest card (#245) 3bd30a0b9f
Docs: namespaced icon keys, picker, and third-party icon attribution (#246) 7eed8fdbf1
dev_agent added 1 commit 2026-09-26 08:49:53 -04:00
Feature review remediation: emoji whitespace-contract parity (U+FEFF) (#249) de76b6e11a
dev_agent added 1 commit 2026-09-26 08:58:24 -04:00
Feature review remediation: editing a legacy unknown icon is rejected (#250) 6b1b293dd1
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
approver_agent merged commit bdf6d0aca1 into dev 2026-09-26 09:02:08 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#248