Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature review remediation: emoji whitespace-contract parity (U+FEFF) #249

Merged
dev_agent merged 1 commits from task/emoji-fecc-parity_8286a894-133f-4582-90fb-88f47eef6628 into feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons 2026-09-26 08:49:52 -04:00
Conversation 1 Commits 1 Files Changed 4
+101 -4
dev_agent commented 2026-09-26 08:48:02 -04:00
Member
Copy Link
Copy Source

Task 8286a894, feature-level remediation on 7eed8fd. Resolves feature review finding NQ-ICON-01 (MEDIUM): Python validate_icon accepted emoji:\uFEFF while the JS resolveIcon rejected it (JS \s includes the BOM). Fix: reject U+FEFF in core/icons.py, mirroring JS \s; ZWJ U+200D remains valid. A shared verdict table tools/icons/emoji-payload-cases.json is checked from both tests/test_core_icons.py and admin Vitest, so future divergence fails one suite. The developer verified U+FEFF was the only Python/JS disagreement across all code points.

Evidence at 23d2197: TZ=UTC uv run pytest -q = 2100 passed; cd admin && npm test = 290 passed; node tools/icons/generate.mjs --check exit 0 (generated registry byte-identical).

Task 8286a894, feature-level remediation on 7eed8fd. Resolves feature review finding NQ-ICON-01 (MEDIUM): Python validate_icon accepted emoji:\uFEFF while the JS resolveIcon rejected it (JS \s includes the BOM). Fix: reject U+FEFF in core/icons.py, mirroring JS \s; ZWJ U+200D remains valid. A shared verdict table tools/icons/emoji-payload-cases.json is checked from both tests/test_core_icons.py and admin Vitest, so future divergence fails one suite. The developer verified U+FEFF was the only Python/JS disagreement across all code points. Evidence at 23d2197: TZ=UTC uv run pytest -q = 2100 passed; cd admin && npm test = 290 passed; node tools/icons/generate.mjs --check exit 0 (generated registry byte-identical).
dev_agent added 1 commit 2026-09-26 08:48:03 -04:00
Core: reject U+FEFF in emoji icon payloads to match the JS resolver 23d21977c6 
Python's validate_icon accepted emoji: (not str.isspace(), category
Cf) while the generated JS isEmojiPayload rejects it via \s, so the backend
could store a key the admin and panel silently fall back on. An exhaustive
code-point sweep shows U+FEFF is the only divergence; add it to the
forbidden set. ZWJ U+200D stays valid.

Add tools/icons/emoji-payload-cases.json, a shared verdict table asserted
by both tests/test_core_icons.py (validate_icon) and the admin Vitest
suite (resolveIcon), so any future divergence fails one of the suites.

Task: 8286a894-133f-4582-90fb-88f47eef6628 (review finding NQ-ICON-01)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit de76b6e11a into feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons 2026-09-26 08:49:52 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#249