Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kids' panel: render the definition icon on the open quest card #245

Merged
dev_agent merged 1 commits from task/panel-definition-icon_5e3f3a5a-f963-4519-87af-95046d40a4e3 into feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons 2026-09-26 08:23:10 -04:00
Conversation 1 Commits 1 Files Changed 4
+255 -127
dev_agent commented 2026-09-26 08:20:35 -04:00
Member
Copy Link
Copy Source

Task 5e3f3a5a (Feature e0855415), built on a93f91d.

Open quest-card icon tiles render the definition's namespaced icon (lucide:/fa:/emoji:, legacy bare as lucide) via the shared registry, falling back to the star for unknown/empty. The sealed card keeps its existing star/seal glyph (no quest icon). Adds jsdom render tests against the built bundle for lucide, fa, emoji, legacy bare, unknown/empty fallback, and sealed-card star; the no-admin-controls source assertion still holds.

Evidence at a5f5086: TZ=UTC uv run pytest -q = 2075 passed, 1 skipped; tests/test_panel_cards.py = 34 passed; frontend build ok (bundle 133,937 bytes, curated 22 FA + 36 Lucide entries, no CDN/runtime fetch).

Task 5e3f3a5a (Feature e0855415), built on a93f91d. Open quest-card icon tiles render the definition's namespaced icon (lucide:/fa:/emoji:, legacy bare as lucide) via the shared registry, falling back to the star for unknown/empty. The sealed card keeps its existing star/seal glyph (no quest icon). Adds jsdom render tests against the built bundle for lucide, fa, emoji, legacy bare, unknown/empty fallback, and sealed-card star; the no-admin-controls source assertion still holds. Evidence at a5f5086: TZ=UTC uv run pytest -q = 2075 passed, 1 skipped; tests/test_panel_cards.py = 34 passed; frontend build ok (bundle 133,937 bytes, curated 22 FA + 36 Lucide entries, no CDN/runtime fetch).
dev_agent added 1 commit 2026-09-26 08:20:35 -04:00
Kids' panel: definition icon on the open quest card only a5f5086617 
The sealed card's tile goes back to the static star (the wax seal is
unchanged); only the open card resolves the definition's namespaced icon
(lucide/fa/emoji, legacy bare name as Lucide, star fallback). The
quest-log jsdom harness now reports each card's tile, and new panel
tests cover every icon kind, the fallback, and the sealed star. Bundle
rebuilt from this branch.

Task: 5e3f3a5a-f963-4519-87af-95046d40a4e3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit 3bd30a0b9f into feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons 2026-09-26 08:23:10 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#245