Photo backfill UI: fix-recipe failures and trigger (Maestro 7a468d2d, Feature 23 task 2) #206

2026-10-11T21:59:36-04:00

2026-10-11 21:59:36 -04:00

Feature 23 task 2: Settings → Regular dinners gains a Find missing photos trigger (202 job followed via useJob) and the fix-recipe sheet shows per-dinner backfill failures with typed reasons and retry. Photoless dinners keep the placeholder until a photo arrives. Photoless/failed dinners excluded by the backend (recipe_unusable, pasted-link failures) hide Search again and explain why.

Maestro task 7a468d2d-4a9b-45f2-b626-a7bed5f671df.

Feature 23 task 2: Settings → Regular dinners gains a Find missing photos trigger (202 job followed via useJob) and the fix-recipe sheet shows per-dinner backfill failures with typed reasons and retry. Photoless dinners keep the placeholder until a photo arrives. Photoless/failed dinners excluded by the backend (recipe_unusable, pasted-link failures) hide Search again and explain why. Maestro task 7a468d2d-4a9b-45f2-b626-a7bed5f671df.

orchestrator-agent added 1 commit 2026-10-11 21:59:37 -04:00

Photo backfill UI: fix-recipe failures and Find missing photos (Maestro 7a468d2d, Feature 23 task 2)

CI / ci (push) Successful in 9m38s

Details

CI / ci (pull_request) Successful in 9m30s

Details

3882f670ca

Settings → Regular dinners gains a "Find missing photos" trigger that
calls POST /api/v1/settings/photo-backfill (202 {id}) and follows the
backfill_dinner_photos job with useJob, showing progress, a summary of
the outcomes, or why it stopped. When the job ends, the dinners, plans
and home queries are read again so found photos show everywhere.

The fix-recipe sheet now shows the dinner's grounding_error as a typed
reason and offers "Search again" (the same backfill), reporting this
dinner's outcome; it is not offered for recipe_unusable, since the
backfill never replaces a pasted link. Regular now parses
grounding_error.

Task: 7a468d2d-4a9b-45f2-b626-a7bed5f671df

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

overseer added 1 commit 2026-10-11 22:21:08 -04:00

Offer Search again only where the photo backfill runs (Maestro 7a468d2d, review F1/F2)

CI / ci (pull_request) Successful in 9m44s

Details

CI / ci (push) Successful in 8m6s

Details

6510ad12c0

F1: every dinner response now carries photo_backfill_eligible, computed
by the exported dinners.PhotoBackfillEligible: the condition
ListPhotoBackfillDinners lists by and GroundFailedDinner and
RefailDinnerGrounding write under (unarchived, failed, no photo, no
pasted recipe_url). A test holds the flag to ListPhotoBackfillDinners
for an eligible dinner and for grounded, linked and archived ones. The
fix-recipe sheet shows "Search again" only when the flag is set, so a
dinner with a pasted link is never offered it, whatever its reason.

F2: a dinner absent from the backfill result now reads "This dinner was
not included in that search." instead of claiming a pasted link.

Task: 7a468d2d-4a9b-45f2-b626-a7bed5f671df

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

review_agent approved these changes

2026-10-11 22:22:28 -04:00

review_agent left a comment

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

approver_agent merged commit e8ec2dac22 into feature/1e5f7fa3-5308-4ced-8c2d-1da1cc6256f9-meal-photos-manual-dinners

2026-10-11 22:55:34 -04:00

orchestrator-agent referenced this pull request

2026-10-11 22:55:50 -04:00

Feature 23: Meal photos for manually added dinners #207

orchestrator-agent referenced this pull request

2026-10-11 23:48:38 -04:00

Release: Feature 23 (Meal photos for manually added dinners) #209