Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature 13: Discover - Side Quest Suggestions #110

Merged
approver_agent merged 10 commits from feature/e3a8e4ea-8dcb-49e8-878f-552a6af109cb-discover-side-quest-suggestions into dev 2026-10-07 05:53:23 -04:00
Conversation 3 Commits 10 Files Changed 59
+8959 -128
orchestrator-agent commented 2026-10-07 04:49:03 -04:00
Member
Copy Link
Copy Source

Feature 13 - "Discover: Side Quest Suggestions". All seven tasks done and independently reviewed:

  • 85a898e1 suggest_side_quests skill v1 (PR #100)
  • b4f2558c Suggestion batches, deck and accept/decline API (PR #102)
  • 1ecc121c Discover deck screen, mock 1a (PR #105)
  • cb7da499 Try it and Pass animations (PR #106)
  • 54c12e9e Swipe gesture (PR #107)
  • ea935fbc Optimistic decisions and deck refetch (PR #108)
  • 5ad0b188 Quest log sheet (PR #109)

Acceptance criteria (feature)

The AI recommends new dinners from the household's Regulars and the household accepts ("Try it") or
declines ("Pass") them on a swipe deck; accepted dinners wait in the Quest log; every card's reason
names at least one real Regular and every card has a grounded photo; declined dishes never reappear;
swipe is never the only path (buttons and ←/→ work); input locks during an exit; the deck never shows
fewer than three cards while suggestions are available; reduced motion uses 200 ms fades; the screen
matches mock 1a; tests pass.

Guardrails

Swipe is never the only path; input locked while an exit animation runs; accepted dinners are not
scheduled immediately (they wait in the Quest log); no silent fallback suggestions when the AI fails -
an error with retry is shown.

Notes

  • dev was merged into this feature branch at the integration step (clean merge); the feature head is
    the merge commit.
  • The Quest-log read (GET /dinners?status=quest_log) now excludes dinners on the current or a future
    plan (server-side, household timezone) so the Quest log means "accepted, not yet scheduled".
  • The AI household context still reads the full quest_log status, including planned dinners, which
    keeps suggestion dedupe conservative.

Feature head: 4d9d8afd8d0a0e1e78f035702e9eec856c35631a (dev is not yet an ancestor; this merges into dev).

Feature 13 - "Discover: Side Quest Suggestions". All seven tasks done and independently reviewed: - 85a898e1 suggest_side_quests skill v1 (PR #100) - b4f2558c Suggestion batches, deck and accept/decline API (PR #102) - 1ecc121c Discover deck screen, mock 1a (PR #105) - cb7da499 Try it and Pass animations (PR #106) - 54c12e9e Swipe gesture (PR #107) - ea935fbc Optimistic decisions and deck refetch (PR #108) - 5ad0b188 Quest log sheet (PR #109) ## Acceptance criteria (feature) The AI recommends new dinners from the household's Regulars and the household accepts ("Try it") or declines ("Pass") them on a swipe deck; accepted dinners wait in the Quest log; every card's reason names at least one real Regular and every card has a grounded photo; declined dishes never reappear; swipe is never the only path (buttons and ←/→ work); input locks during an exit; the deck never shows fewer than three cards while suggestions are available; reduced motion uses 200 ms fades; the screen matches mock 1a; tests pass. ## Guardrails Swipe is never the only path; input locked while an exit animation runs; accepted dinners are not scheduled immediately (they wait in the Quest log); no silent fallback suggestions when the AI fails - an error with retry is shown. ## Notes - `dev` was merged into this feature branch at the integration step (clean merge); the feature head is the merge commit. - The Quest-log read (`GET /dinners?status=quest_log`) now excludes dinners on the current or a future plan (server-side, household timezone) so the Quest log means "accepted, not yet scheduled". - The AI household context still reads the full `quest_log` status, including planned dinners, which keeps suggestion dedupe conservative. Feature head: `4d9d8afd8d0a0e1e78f035702e9eec856c35631a` (dev is not yet an ancestor; this merges into dev).
orchestrator-agent added 8 commits 2026-10-07 04:49:03 -04:00
suggest_side_quests skill v1 (#100)
CI / ci (push) Successful in 2m32s
Details
7d1e983fc8 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Suggestion batches, deck and Try it / Pass API (#102)
CI / ci (push) Successful in 2m42s
Details
4c34467f8b 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Discover deck screen (mock 1a) (#105)
CI / ci (push) Successful in 2m39s
Details
db677d591f 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Try it and Pass animations (Discover deck) (#106)
CI / ci (push) Successful in 2m41s
Details
c0ea1b9323 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Swipe gesture on the Discover deck (#107)
CI / ci (push) Successful in 2m37s
Details
9088c313cc 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Optimistic Discover decisions and deck refill (#108)
CI / ci (push) Successful in 2m39s
Details
a866dfad06 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Quest log sheet on Discover (#109)
CI / ci (push) Successful in 3m1s
Details
721a79bce9 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Merge remote-tracking branch 'origin/dev' into feature/e3a8e4ea-8dcb-49e8-878f-552a6af109cb-discover-side-quest-suggestions
CI / ci (pull_request) Successful in 2m43s
Details
CI / ci (push) Successful in 2m54s
Details
4d9d8afd8d
review_agent requested changes 2026-10-07 04:52:20 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
approver_agent added 1 commit 2026-10-07 05:20:11 -04:00
Feature 13 integration fix: deck error surfacing, active-batch tracking, modal key scope, three-card deck (#111)
CI / ci (push) Successful in 2m43s
Details
CI / ci (pull_request) Successful in 2m46s
Details
a05d57cb2e 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
review_agent requested changes 2026-10-07 05:23:04 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
approver_agent added 1 commit 2026-10-07 05:47:23 -04:00
Feature 13 integration fix 2: report a failed batch on deck load (#112)
CI / ci (push) Successful in 2m43s
Details
CI / ci (pull_request) Successful in 2m43s
Details
b087f3a427 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 5291457214 into dev 2026-10-07 05:53:23 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#110