Feature 13 integration fix: deck error surfacing, active-batch tracking, modal key scope, three-card deck #111

2026-10-07T05:05:09-04:00

2026-10-07 05:05:09 -04:00

Feature-integration corrections for Feature 13 (PR #110) at head 4d9d8af. Maestro task 4fc551f0-3c11-4c15-b638-f2c08a28eb29.

F13-01 (HIGH): replenish/batch failures and Retry now render alongside a non-empty deck, not only when it is empty.
F13-02 (HIGH): the client learns the active batch's job from the server on deck load and when a decision joins an existing batch, so an emptied deck shows skeletons while suggestions are being produced rather than "All caught up".
F13-03 (HIGH): arrow-key decisions are scoped so an open sheet or confirmation dialog does not decide the background card.
F13-04 (HIGH): the deck keeps three visible depths when supply is short, instead of showing fewer than three cards while suggestions remain.

Checks: gofmt, go vet, go test -race -count=1 ./..., CGO_ENABLED=0 go build ./..., make sqlc-check (no drift), web typecheck + tests + build, make build, docker build . - all passing.

Feature-integration corrections for Feature 13 (PR #110) at head `4d9d8af`. Maestro task `4fc551f0-3c11-4c15-b638-f2c08a28eb29`. - F13-01 (HIGH): replenish/batch failures and Retry now render alongside a non-empty deck, not only when it is empty. - F13-02 (HIGH): the client learns the active batch's job from the server on deck load and when a decision joins an existing batch, so an emptied deck shows skeletons while suggestions are being produced rather than "All caught up". - F13-03 (HIGH): arrow-key decisions are scoped so an open sheet or confirmation dialog does not decide the background card. - F13-04 (HIGH): the deck keeps three visible depths when supply is short, instead of showing fewer than three cards while suggestions remain. Checks: gofmt, go vet, go test -race -count=1 ./..., CGO_ENABLED=0 go build ./..., make sqlc-check (no drift), web typecheck + tests + build, make build, docker build . - all passing.

orchestrator-agent added 1 commit 2026-10-07 05:05:09 -04:00

Surface replenish failures, follow the active batch, scope deck keys, keep three deck depths

CI / ci (push) Successful in 3m2s

Details

CI / ci (pull_request) Successful in 2m44s

Details

af58caac94

Fixes the Feature 13 review findings on the Discover deck (Maestro task
4fc551f0-3c11-4c15-b638-f2c08a28eb29):

- F13-01: a batch failure (start, poll or job) is shown with its Retry
  whatever the deck has, so a replenish that fails while cards remain is
  no longer silent until the deck runs out.
- F13-02: GET /api/v1/suggestions/deck reports the batch pending or
  running (active_batch, read in the deck's snapshot), and a decision
  that calls for a replenish returns the job of the batch it started or
  joined. The page follows a newly reported active batch, so a reopened
  page or a second session shows skeleton cards while the batch runs
  instead of "All caught up".
- F13-03: ← / → leave the deck alone while it is inert behind a modal
  (the Quest log sheet or its confirmation).
- F13-04: a one- or two-card deck keeps all three depths: skeleton cards
  stand in for the missing ones while a batch finds more Side quests,
  blank stack-edge cards while none is coming.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

review_agent requested changes

2026-10-07 05:09:35 -04:00

Dismissed

review_agent left a comment

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

overseer added 1 commit 2026-10-07 05:13:50 -04:00

Fail orphaned suggestion batches before reporting the deck's active batch

CI / ci (push) Successful in 3m5s

Details

CI / ci (pull_request) Successful in 2m45s

Details

71060515bd

Deck returned a pending or running batch's job id without checking that
the job was still queued or running, so after a restart failed the job
the page polled a dead job as the active batch. Deck and startBatch now
share activeBatch, which runs FailOrphanedSuggestionBatches before
reading the active batch; Deck therefore uses a write transaction.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

review_agent approved these changes

2026-10-07 05:18:02 -04:00

review_agent left a comment

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

approver_agent merged commit a05d57cb2e into feature/e3a8e4ea-8dcb-49e8-878f-552a6af109cb-discover-side-quest-suggestions

2026-10-07 05:20:11 -04:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#111