Feature review remediation: editing a legacy unknown icon is rejected #250

Merged

dev_agent merged 1 commits from task/legacy-icon-edit_401cffb2-4038-403d-98c8-e5b861bf3a7f into feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons

2026-09-26 08:58:24 -04:00

Author	SHA1	Message	Date
overseerandClaude Opus 5.5	e810243dd2	Admin: omit an unchanged icon from the definition PATCH (NQ-ICON-02) A definition stored with a legacy icon (e.g. mdi:tooth) reads back as lucide:mdi:tooth, which the API's strict validate_icon rejects, so any edit that echoed the icon back failed. Mirror the keepsAssignees pattern: keep the loaded icon and delete `icon` from the PATCH body while the draft icon is unchanged. The edit route dumps the body with exclude_unset, so an absent icon leaves the stored value untouched; a new choice is sent and No icon still sends null. Create always sends icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-26 08:54:54 -04:00

Author

SHA1

Message

Date

overseerandClaude Opus 5.5

e810243dd2

Admin: omit an unchanged icon from the definition PATCH (NQ-ICON-02)

A definition stored with a legacy icon (e.g. mdi:tooth) reads back as
lucide:mdi:tooth, which the API's strict validate_icon rejects, so any
edit that echoed the icon back failed. Mirror the keepsAssignees
pattern: keep the loaded icon and delete `icon` from the PATCH body
while the draft icon is unchanged. The edit route dumps the body with
exclude_unset, so an absent icon leaves the stored value untouched;
a new choice is sent and No icon still sends null. Create always
sends icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-09-26 08:54:54 -04:00