Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature review remediation: editing a legacy unknown icon is rejected #250

Merged
dev_agent merged 1 commits from task/legacy-icon-edit_401cffb2-4038-403d-98c8-e5b861bf3a7f into feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons 2026-09-26 08:58:24 -04:00
Conversation 1 Commits 1 Files Changed 2
+118 -6
dev_agent commented 2026-09-26 08:57:10 -04:00
Member
Copy Link
Copy Source

Task 401cffb2, feature-level remediation on de76b6e. Resolves feature review NQ-ICON-02 (MEDIUM): a definition stored with a legacy/unknown icon (e.g. mdi:tooth, read back as lucide:mdi:tooth) could not be edited because the unchanged icon was PATCHed and the strict validator rejected it. Fix mirrors the existing keepsAssignees pattern: on edit, an unchanged icon is omitted from the PATCH body (absent means unchanged; verified in api/routes_admin.py model_dump(exclude_unset=True)); a new lucide:/fa:/emoji: choice or null clear is still sent; create still sends icon.

Evidence at e810243: cd admin && npm test = 297 passed; TZ=UTC uv run pytest -q = 2100 passed; admin build ok. Regression test uses lucide:mdi:tooth with the fake API returning 422 for a second colon.

Task 401cffb2, feature-level remediation on de76b6e. Resolves feature review NQ-ICON-02 (MEDIUM): a definition stored with a legacy/unknown icon (e.g. mdi:tooth, read back as lucide:mdi:tooth) could not be edited because the unchanged icon was PATCHed and the strict validator rejected it. Fix mirrors the existing keepsAssignees pattern: on edit, an unchanged icon is omitted from the PATCH body (absent means unchanged; verified in api/routes_admin.py model_dump(exclude_unset=True)); a new lucide:/fa:/emoji: choice or null clear is still sent; create still sends icon. Evidence at e810243: cd admin && npm test = 297 passed; TZ=UTC uv run pytest -q = 2100 passed; admin build ok. Regression test uses lucide:mdi:tooth with the fake API returning 422 for a second colon.
dev_agent added 1 commit 2026-09-26 08:57:10 -04:00
Admin: omit an unchanged icon from the definition PATCH (NQ-ICON-02) e810243dd2 
A definition stored with a legacy icon (e.g. mdi:tooth) reads back as
lucide:mdi:tooth, which the API's strict validate_icon rejects, so any
edit that echoed the icon back failed. Mirror the keepsAssignees
pattern: keep the loaded icon and delete `icon` from the PATCH body
while the draft icon is unchanged. The edit route dumps the body with
exclude_unset, so an absent icon leaves the stored value untouched;
a new choice is sent and No icon still sends null. Create always
sends icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit 6b1b293dd1 into feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons 2026-09-26 08:58:24 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#250