Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Admin PWA: Lucide + Font Awesome + emoji icon picker #243

Merged
dev_agent merged 2 commits from task/admin-icon-picker_7c29d925-3ec9-4b04-8bf1-453896f2b4f5 into feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons 2026-09-26 08:15:13 -04:00
Conversation 1 Commits 2 Files Changed 4
+359 -23
dev_agent commented 2026-09-26 08:06:51 -04:00
Member
Copy Link
Copy Source

Task 7c29d925 (Feature e0855415), built on a12451b.

Adds a Font Awesome group and an emoji input to the definition edit sheet's icon picker alongside the curated Lucide set; each choice stores the exact namespaced key (lucide:/fa:/emoji:) in the create/edit body; an existing namespaced or legacy bare icon pre-fills the correct selection; the definition list renders lucide, fa and emoji and falls back to the generic task glyph for unknown/empty. Invalid emoji input is blocked with the same 1-8 code point rule as the registry/backend.

Evidence at 7f2f903: cd admin && npm test = 265 passed; cd admin && npm run build ok; TZ=UTC uv run pytest -q = 2072 passed. No CDN/remote URL; frontend/, core/ and api/ untouched.

Task 7c29d925 (Feature e0855415), built on a12451b. Adds a Font Awesome group and an emoji input to the definition edit sheet's icon picker alongside the curated Lucide set; each choice stores the exact namespaced key (lucide:/fa:/emoji:) in the create/edit body; an existing namespaced or legacy bare icon pre-fills the correct selection; the definition list renders lucide, fa and emoji and falls back to the generic task glyph for unknown/empty. Invalid emoji input is blocked with the same 1-8 code point rule as the registry/backend. Evidence at 7f2f903: cd admin && npm test = 265 passed; cd admin && npm run build ok; TZ=UTC uv run pytest -q = 2072 passed. No CDN/remote URL; frontend/, core/ and api/ untouched.
dev_agent added 1 commit 2026-09-26 08:06:51 -04:00
Admin: Lucide, Font Awesome and emoji icon picker for definitions 7f2f903fa9 
The edit sheet offers the curated Font Awesome subset and an emoji field
next to the Lucide grid, storing lucide:<name>, fa:<name> or
emoji:<grapheme>; an invalid emoji blocks the save. Existing fa/emoji/
legacy icons prefill the matching choice, and the definition list draws
any resolveIcon result (glyph, emoji text, or the fallback task glyph).

Task 7c29d925-3ec9-4b04-8bf1-453896f2b4f5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
overseer added 1 commit 2026-09-26 08:10:42 -04:00
Admin: validate raw emoji input instead of trimming it 59ff392433 
The backend rejects whitespace in emoji keys, so an entry like " 🐶 "
must fail the picker's validation rather than be saved as emoji:🐶.
Only an exactly empty field clears the icon; whitespace-only text now
shows the invalid-emoji error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit a93f91d4af into feature/e0855415-bb64-4082-b5ae-c957eaa7307d-expanded-task-icons 2026-09-26 08:15:13 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#243