Core/API: namespaced icon keys (lucide/fa/emoji) with legacy back-compat #241

2026-09-26T07:24:18-04:00

dev_agent commented

2026-09-26 07:24:18 -04:00

Task 707994b7 (Feature e0855415). Adds one core icon module (validate_icon / normalize_icon_for_read) so quest-definition icons accept lucide:, fa: and emoji: keys with legacy bare names normalized to lucide, wired into create/edit writes and into the admin definition response and panel snapshot reads. No stored-data migration. Developer evidence at 7af0b5a: TZ=UTC uv run pytest -q green; new tests/test_core_icons.py (50 cases) plus create/edit and API back-compat tests. See the PR conversation for the flagged edge (an old mdi:tooth value reads back as lucide:mdi:tooth, which the frontend falls back on).

Task 707994b7 (Feature e0855415). Adds one core icon module (validate_icon / normalize_icon_for_read) so quest-definition icons accept `lucide:`, `fa:` and `emoji:` keys with legacy bare names normalized to lucide, wired into create/edit writes and into the admin definition response and panel snapshot reads. No stored-data migration. Developer evidence at 7af0b5a: TZ=UTC uv run pytest -q green; new tests/test_core_icons.py (50 cases) plus create/edit and API back-compat tests. See the PR conversation for the flagged edge (an old `mdi:tooth` value reads back as `lucide:mdi:tooth`, which the frontend falls back on).

dev_agent added 1 commit 2026-09-26 07:24:19 -04:00

Namespace quest definition icon keys with legacy back-compat 7af0b5a6cc

Add core/icons.py as the one place icon keys are validated and
normalized. A definition icon is now stored as lucide:<name>,
fa:<name> or emoji:<payload> (at most 8 code points, no whitespace,
control characters or markup). Create and edit validate strictly and
store the canonical form; a legacy bare name is stored as
lucide:<name>, and None still clears the icon.

Reads normalize leniently so existing bare-name rows need no data
migration: the admin quest-definition response and the panel snapshot's
per-instance icon both return the namespaced form.

Task 707994b7.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

overseer added 1 commit 2026-09-26 07:33:21 -04:00

Resolve namespaced Lucide icons in the admin lookup and picker a64b619bee

The API now returns definition icons as lucide:<name>, but the admin
looked up and compared bare names only, so every icon rendered as the
generic fallback and nothing was selected in the edit picker (NQ-241-1).

Add normalizeDefinitionIconName as the one rule for both surfaces:
lucide:<name> and a legacy bare <name> give <name>; fa:, emoji: and
unknown namespaces give null (the fallback tile). Tapping a Lucide
choice now stores the canonical lucide:<name>; No icon still clears.

Task 707994b7.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

overseer added 1 commit 2026-09-26 07:38:22 -04:00

Reject edge whitespace and controls in icon keys instead of trimming 430f8abc12

validate_icon stripped the whole value before validating, so
`emoji:🐕 `, `emoji:🐕\n` and `emoji:🐕\x1c` were silently accepted as
`emoji:🐕`. Validate the raw namespace, name and emoji payload; a
whitespace-only value still clears the icon. Padded keys such as
`lucide:dog ` are now rejected naming `icon` (NQ-241-3).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>