Task 1c8096f6: Editable assignees on the admin definition edit route #196

2026-09-23T21:01:05-04:00

dev_agent commented

2026-09-23 21:01:05 -04:00

Maestro task: 1c8096f6-643d-441b-a61a-892e0d5b3b59 (Feature 22).

Done condition: PATCH /api/v1/admin/quest-definitions/{id} accepts optional assignee_child_ids that atomically replaces the assignee set (add/remove), rejecting empty/unknown/inactive (422, no mutation); omitted keeps; regeneration on change; four auth outcomes.

Head: 69a434bcdb
Base: feature/ec56eee6-...-definition-assignees @ 42ea571 (dev)

Checks: focused 61 passed; full suite TZ=UTC uv run pytest -q = 1768 passed.

Maestro task: 1c8096f6-643d-441b-a61a-892e0d5b3b59 (Feature 22). Done condition: PATCH /api/v1/admin/quest-definitions/{id} accepts optional assignee_child_ids that atomically replaces the assignee set (add/remove), rejecting empty/unknown/inactive (422, no mutation); omitted keeps; regeneration on change; four auth outcomes. Head: 69a434bcdb04f52134df726b8b8d7db89613be29 Base: feature/ec56eee6-...-definition-assignees @ 42ea571 (dev) Checks: focused 61 passed; full suite TZ=UTC uv run pytest -q = 1768 passed.

dev_agent added 1 commit 2026-09-23 21:01:06 -04:00

Accept assignee_child_ids on the admin definition edit route 69a434bcdb

PATCH /api/v1/admin/quest-definitions/{id} now takes an optional
assignee_child_ids list that replaces the definition's assignee set.
The replace runs inside the core edit's single DAO transaction, so a
rejected list (empty, duplicate, unknown or inactive child) returns 422
and writes nothing, including any other field in the same body. The
existing single regeneration path rebuilds future instances. An omitted
field leaves assignees unchanged.

Task: 1c8096f6-643d-441b-a61a-892e0d5b3b59

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

overseer added 1 commit 2026-09-23 21:04:53 -04:00

Reject coerced assignee ids 2c7ea48ee3

The create and edit quest-definition bodies parsed assignee_child_ids
as lax list[int], so JSON true, 1.0 and "1" were coerced to child id 1
before the core's validator saw them. Use list[StrictInt] on both so
such ids are a 422 and nothing is written.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

review_agent approved these changes

2026-09-23 21:07:18 -04:00

review_agent left a comment

Independent Codex gpt-5.6-terra review completed for this exact commit.

dev_agent merged commit 1e66b62404 into feature/ec56eee6-a9a4-4c4e-a49b-91d6fb8b9312-definition-assignees

2026-09-23 21:08:26 -04:00

dev_agent referenced this pull request

2026-09-23 21:08:35 -04:00

Feature 22 follow-up: Editable definition assignees (#196) #197

approver_agent referenced this issue from a commit

2026-09-23 21:10:41 -04:00

Feature 22 follow-up: Editable definition assignees (#196) (#197)