Extract the storage layer into core/ #142

2026-09-21T14:21:00-04:00

dev_agent commented

2026-09-21 14:21:00 -04:00

Task d0b691d8 (Feature 15 — Domain Core Extraction): move schema.py, migrations.py, db.py, store.py, and the dao_* modules into a new Home-Assistant-free core/ package, leaving re-export shims in custom_components/nestquest/ plus make_database(hass)/async_get_db_path(hass) adapters.

core/db.py: NestQuestDatabase now takes an executor callable instead of hass; core/store.py takes a path. Nothing in core/ imports homeassistant.
Tests: 54 NestQuestDatabase(...) call sites pass hass.async_add_executor_job; the 5 cancellation/gating tests in test_db.py use a dynamic executor_for(hass) wrapper so reassigning hass.async_add_executor_job after construction is still observed (fixes the hang at test_cancel_during_open_closes_abandoned_connection).
Source-scan tests retarget core.db; the sqlite3 scan exempts core/db.py; store mkdir now asserts asyncio.to_thread.
grep -r "import homeassistant" core/ is empty; python -c "import core" works; uv run pytest -q is fully green (1496 passed, matching the pre-extraction baseline).

Task d0b691d8 (Feature 15 — Domain Core Extraction): move schema.py, migrations.py, db.py, store.py, and the dao_* modules into a new Home-Assistant-free `core/` package, leaving re-export shims in `custom_components/nestquest/` plus `make_database(hass)`/`async_get_db_path(hass)` adapters. - `core/db.py`: `NestQuestDatabase` now takes an executor callable instead of `hass`; `core/store.py` takes a path. Nothing in `core/` imports `homeassistant`. - Tests: 54 `NestQuestDatabase(...)` call sites pass `hass.async_add_executor_job`; the 5 cancellation/gating tests in `test_db.py` use a dynamic `executor_for(hass)` wrapper so reassigning `hass.async_add_executor_job` after construction is still observed (fixes the hang at `test_cancel_during_open_closes_abandoned_connection`). - Source-scan tests retarget `core.db`; the sqlite3 scan exempts `core/db.py`; `store` mkdir now asserts `asyncio.to_thread`. - `grep -r "import homeassistant" core/` is empty; `python -c "import core"` works; `uv run pytest -q` is fully green (1496 passed, matching the pre-extraction baseline).

dev_agent added 1 commit 2026-09-21 14:21:00 -04:00

Extract the storage layer into core 518f8b80ae

overseer added 1 commit 2026-09-21 14:28:53 -04:00

Bundle core inside the integration fb3c6601c1

HACS and the manual install copy only custom_components/nestquest, so
the integration shipped with a top-level 'core' package that was never
deployed and failed with ModuleNotFoundError: No module named 'core'.

Move core/ into custom_components/nestquest/core/, repoint the
re-export shims to relative '.core.X' imports, and update tests
(import paths, monkeypatch targets, caplog logger) to the new
'custom_components.nestquest.core.X' location. The integration is now
self-contained: nothing under custom_components/nestquest reaches
outside its own tree, the migrations logger becomes
custom_components.nestquest.core.migrations, and the SQL-leak guard
allowlists point at the new core/ paths.

uv run pytest -q: 1496 passed.

overseer referenced this issue from a commit

2026-09-21 14:43:47 -04:00

Address PR #142 review: core isolation invariant and shim fixes

overseer added 1 commit 2026-09-21 14:43:47 -04:00

Address PR #142 review: core isolation invariant and shim fixes 43f68fb7a3

- Point recurrence purity scan at custom_components.nestquest.core.recurrence
  (P2.1); the shim only re-exports, so the real model was no longer scanned.
- Make test_const/test_config_flow/test_dao_matrix module scans recursive
  (rglob) so custom_components/nestquest/core/ is covered (P2.2, P2.3);
  const.py name exclusion retained.
- Add test_core_isolation: AST-scan every core module for homeassistant
  imports, relative imports climbing out of core (level > 1), absolute
  imports reaching custom_components.nestquest.<not core>, and bare
  'import core'/'from core' (P2.4).
- Drop the private re-export of _month_end/_nth_weekday_of_month from the
  recurrence shim; those are test-only, so move the two test imports to
  custom_components.nestquest.core.recurrence (P2.1/P3.1).
- Fix shim docstrings and core/__init__.py to reference
  custom_components.nestquest.core.* instead of the unimportable 'core.*'
  paths (P3.2).
- Note the migrations logger namespace move to
  custom_components.nestquest.core.migrations in RELEASE_NOTES.md (P3.3).

dev_agent merged commit 1503774e85 into feature/a9513378-856c-4ced-8722-c99850d3a524-domain-core-extraction

2026-09-21 14:48:01 -04:00

orchestrator-agent referenced this pull request

2026-09-21 16:01:18 -04:00

Feature 15: Domain Core Extraction #146

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#142