Integration fix 2: conditional recipe repairs and no pasted links in logs (Feature 12 review F1, F2) #96

Merged

approver_agent merged 3 commits from task/feature12-integration-fix2_8741cedb-1849-4e3f-8d05-f5648c77c7ee into feature/2066f34b-5804-410a-859b-f87021a8ae6c-regular-dinners-onboarding

2026-10-06 20:26:57 -04:00

Author	SHA1	Message	Date
dev_agentandClaude Opus 5.5	82f8f668bf	Log every unexpected recipe grounding failure by fixed reason CI / ci (push) Successful in 2m41s Details CI / ci (pull_request) Successful in 2m23s Details Wrap an initial dinner read failure on the candidate and link path, and any manual-recipe read, store or write failure, in ErrGroundFailed so the handler logs only reason=ground_failed and the dinner id, never database text. Not-found, archived and conflict answers stay distinct. Strengthen TestFixInFlightKeepsMemberEdits: start from populated method, minutes and difficulty, edit each in flight in turn, and require the edit kept and the untouched populated fields replaced by the recipe's values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-06 20:21:12 -04:00
dev_agentandClaude Opus 5.5	1dd53767f7	Guard recipe repairs against same-normalized renames and member edits CI / ci (push) Successful in 2m41s Details CI / ci (pull_request) Successful in 2m31s Details F1-1: GroundDinner also compares the observed raw name, so renaming "Grandma's stew" to "Easy Grandma's stew" (same normalized_name) while a link is grounding is ErrGroundConflict, not attached to the renamed dinner. F1-2: A method, minutes_total or difficulty no longer as observed before grounding is kept over the recipe's value, as GroundPendingDinner keeps values a member set while a dinner was pending. F2-1: Failing to record a grounded candidate or link on the dinner (or to read it back after a rejected write) wraps ErrGroundFailed, so the API logs reason=ground_failed with the dinner id, never the database error. Maestro task 8741cedb-1849-4e3f-8d05-f5648c77c7ee. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-06 20:11:32 -04:00
dev_agentandClaude Opus 5.5	5c4c507ee6	Make recipe repairs conditional and keep pasted links out of logs CI / ci (push) Successful in 2m34s Details CI / ci (pull_request) Successful in 2m30s Details F1: A candidate or link repair now writes the dinner only if it is still unarchived and as observed before grounding (normalized_name, grounding_status, grounding_revision and recipe_id). A dinner renamed or grounded some other way meanwhile is ErrGroundConflict (409 ground_conflict); one archived, before or during the repair, is ErrArchived (409 dinner_archived). Manual repairs reject archived dinners too. F2: Any failure grounding a candidate or link by hand wraps ErrGroundFailed, which the API logs as reason=ground_failed with the dinner id only, never the pasted link or dependency error text. GroundURL no longer formats the link into its error. Maestro task 8741cedb-1849-4e3f-8d05-f5648c77c7ee. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-06 20:03:05 -04:00

Author

SHA1

Message

Date

dev_agentandClaude Opus 5.5

82f8f668bf

Log every unexpected recipe grounding failure by fixed reason

CI / ci (push) Successful in 2m41s

Details

CI / ci (pull_request) Successful in 2m23s

Details

Wrap an initial dinner read failure on the candidate and link path, and
any manual-recipe read, store or write failure, in ErrGroundFailed so the
handler logs only reason=ground_failed and the dinner id, never database
text. Not-found, archived and conflict answers stay distinct.

Strengthen TestFixInFlightKeepsMemberEdits: start from populated method,
minutes and difficulty, edit each in flight in turn, and require the edit
kept and the untouched populated fields replaced by the recipe's values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-06 20:21:12 -04:00

dev_agentandClaude Opus 5.5

1dd53767f7

Guard recipe repairs against same-normalized renames and member edits

CI / ci (push) Successful in 2m41s

Details

CI / ci (pull_request) Successful in 2m31s

Details

F1-1: GroundDinner also compares the observed raw name, so renaming
"Grandma's stew" to "Easy Grandma's stew" (same normalized_name) while a
link is grounding is ErrGroundConflict, not attached to the renamed
dinner.

F1-2: A method, minutes_total or difficulty no longer as observed before
grounding is kept over the recipe's value, as GroundPendingDinner keeps
values a member set while a dinner was pending.

F2-1: Failing to record a grounded candidate or link on the dinner (or to
read it back after a rejected write) wraps ErrGroundFailed, so the API
logs reason=ground_failed with the dinner id, never the database error.

Maestro task 8741cedb-1849-4e3f-8d05-f5648c77c7ee.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-06 20:11:32 -04:00

dev_agentandClaude Opus 5.5

5c4c507ee6

Make recipe repairs conditional and keep pasted links out of logs

CI / ci (push) Successful in 2m34s

Details

CI / ci (pull_request) Successful in 2m30s

Details

F1: A candidate or link repair now writes the dinner only if it is still
unarchived and as observed before grounding (normalized_name,
grounding_status, grounding_revision and recipe_id). A dinner renamed or
grounded some other way meanwhile is ErrGroundConflict (409
ground_conflict); one archived, before or during the repair, is
ErrArchived (409 dinner_archived). Manual repairs reject archived dinners
too.

F2: Any failure grounding a candidate or link by hand wraps
ErrGroundFailed, which the API logs as reason=ground_failed with the
dinner id only, never the pasted link or dependency error text.
GroundURL no longer formats the link into its error.

Maestro task 8741cedb-1849-4e3f-8d05-f5648c77c7ee.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-06 20:03:05 -04:00