Feature 01 task 4: Makefile and multi-stage Dockerfile #5

Merged

approver_agent merged 3 commits from task/makefile-dockerfile_e86810e7-76db-4f58-a4a5-bd91d480fdd5 into feature/19ad7feb-aba0-4b76-ab70-c47d71ed5e76-repository-scaffold-and-ci

2026-10-02 23:06:58 -04:00

Author	SHA1	Message	Date
dev_agentandClaude Opus 5.5	9b66ba0ff5	Fix review findings F1-F3 for Docker context, health check and version Independent review Approved — 0 high findings (#5) Details F1: exclude generated internal/frontend/dist from the Docker build context. F2: derive the health check host from MEALQUEST_HTTP_ADDR, mapping wildcard hosts and localhost to 127.0.0.1 and keeping IPv6 brackets. F3: compute the -dirty suffix ignoring the generated embed output, so a rebuild of a clean checkout is not stamped dirty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-02 23:02:31 -04:00
dev_agentandClaude Opus 5.5	2e5724d150	Fix review findings F1 and F2 for the Dockerfile and .dockerignore Independent review Not signed off — 0 high, 2 medium, 1 low (#5) Details F1: derive the HEALTHCHECK port from MEALQUEST_HTTP_ADDR so an overridden listen port is still probed at /health. F2: make key/certificate exclusions recursive (*/.pem, */.key) and add */.p12, */.pfx, */.jks, */.keystore so nested local secrets never enter the build context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-02 22:55:44 -04:00
dev_agentandClaude Opus 5.5	4dfc7baa2d	Add Makefile dev/test/docker targets and multi-stage Dockerfile Independent review Not signed off — 0 high, 2 medium (#5) Details Makefile: dev runs the Go server (:8080) and Vite (:5173) together and stops both on Ctrl-C; test runs the gofmt check, go vet, go test -race and npm ci/typecheck/test; build stamps the version via -ldflags into a static CGO_ENABLED=0 binary; docker builds the root Dockerfile. VERSION defaults to git describe with a dev fallback. Dockerfile: digest-pinned Node 22, Go 1.25 and Alpine 3.22 stages; the runtime runs as uid 10001 with /data as a volume, EXPOSE 8080 and a HEALTHCHECK on /health. .dockerignore keeps VCS, design, dependencies, build output, databases and secrets out of the context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-02 22:50:16 -04:00

Author

SHA1

Message

Date

dev_agentandClaude Opus 5.5

9b66ba0ff5

Fix review findings F1-F3 for Docker context, health check and version

Independent review Approved — 0 high findings (#5)

Details

F1: exclude generated internal/frontend/dist from the Docker build context.
F2: derive the health check host from MEALQUEST_HTTP_ADDR, mapping wildcard
hosts and localhost to 127.0.0.1 and keeping IPv6 brackets.
F3: compute the -dirty suffix ignoring the generated embed output, so a
rebuild of a clean checkout is not stamped dirty.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-02 23:02:31 -04:00

dev_agentandClaude Opus 5.5

2e5724d150

Fix review findings F1 and F2 for the Dockerfile and .dockerignore

Independent review Not signed off — 0 high, 2 medium, 1 low (#5)

Details

F1: derive the HEALTHCHECK port from MEALQUEST_HTTP_ADDR so an overridden
listen port is still probed at /health.
F2: make key/certificate exclusions recursive (**/*.pem, **/*.key) and add
**/*.p12, **/*.pfx, **/*.jks, **/*.keystore so nested local secrets never
enter the build context.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-02 22:55:44 -04:00

dev_agentandClaude Opus 5.5

4dfc7baa2d

Add Makefile dev/test/docker targets and multi-stage Dockerfile

Independent review Not signed off — 0 high, 2 medium (#5)

Details

Makefile: dev runs the Go server (:8080) and Vite (:5173) together and
stops both on Ctrl-C; test runs the gofmt check, go vet, go test -race and
npm ci/typecheck/test; build stamps the version via -ldflags into a static
CGO_ENABLED=0 binary; docker builds the root Dockerfile. VERSION defaults
to git describe with a dev fallback.

Dockerfile: digest-pinned Node 22, Go 1.25 and Alpine 3.22 stages; the
runtime runs as uid 10001 with /data as a volume, EXPOSE 8080 and a
HEALTHCHECK on /health. .dockerignore keeps VCS, design, dependencies,
build output, databases and secrets out of the context.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-02 22:50:16 -04:00