Fix review findings F1 and F2 for the Dockerfile and .dockerignore
Independent review Not signed off — 0 high, 2 medium, 1 low (#5)

F1: derive the HEALTHCHECK port from MEALQUEST_HTTP_ADDR so an overridden
listen port is still probed at /health.
F2: make key/certificate exclusions recursive (**/*.pem, **/*.key) and add
**/*.p12, **/*.pfx, **/*.jks, **/*.keystore so nested local secrets never
enter the build context.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-02 22:55:44 -04:00
co-authored by Claude Opus 5.5
parent 4dfc7baa2d
commit 2e5724d150
2 changed files with 9 additions and 3 deletions
+6 -2
View File
@@ -16,5 +16,9 @@ bin/
.env*
**/.env*
deploy/secrets/
*.pem
*.key
**/*.pem
**/*.key
**/*.p12
**/*.pfx
**/*.jks
**/*.keystore
+3 -1
View File
@@ -32,6 +32,8 @@ ENV MEALQUEST_HTTP_ADDR=:8080 \
VOLUME /data
EXPOSE 8080
USER 10001:10001
# Probe the port from MEALQUEST_HTTP_ADDR (text after the last colon) so an
# overridden listen address stays healthy.
HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
CMD wget -q -O /dev/null http://127.0.0.1:8080/health || exit 1
CMD wget -q -O /dev/null "http://127.0.0.1:${MEALQUEST_HTTP_ADDR##*:}/health" || exit 1
ENTRYPOINT ["/usr/local/bin/mealquest"]