Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Suggest batch: replace a card dropped at final store, correct failed-batch doc (Maestro 244f9834) #197

Merged
approver_agent merged 3 commits from task/suggest-batch-replacement_244f9834-faa8-4bb8-b5e6-43677dec0cc0 into feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness 2026-10-11 14:45:24 -04:00
Conversation 2 Commits 3 Files Changed 3
+163 -32
3 Commits
Author SHA1 Message Date
dev_agentandClaude Opus 5.5 8a1c780137 Recheck a Side quest held from an earlier round in the replacement test
CI / ci (push) Successful in 8m15s
Details
CI / ci (pull_request) Successful in 8m10s
Details 
TestBatchReplacesSideQuestMadeIneligibleWhileHeld now leaves the first
round one short (Fajita Dish B is ungroundable), blocks the second
round, and adds a dinner repeating Fajita Dish A, held from the first
round. A further spare lets a third round ground its replacement; the
test asserts BatchSize stored, 2 dropped and one new_suggestions.

Maestro task 244f9834-faa8-4bb8-b5e6-43677dec0cc0, finding MQ-172-3-TEST.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-11 12:08:48 -04:00
dev_agent 6e8b44bb15 Merge remote-tracking branch 'origin/feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness' into task/suggest-batch-replacement_244f9834-faa8-4bb8-b5e6-43677dec0cc0
CI / ci (push) Successful in 8m10s
Details
CI / ci (pull_request) Successful in 8m15s
Details
2026-10-11 10:35:25 -04:00
dev_agentandClaude Opus 5.5 0942e65392 Replace a held Side quest made ineligible before a batch's final store
CI / ci (push) Successful in 9m38s
Details
CI / ci (pull_request) Successful in 8m21s
Details 
A notifying (scheduled or manual) suggestion batch held each round's
grounded Side quests and only checked them at its single final store, so
a household change during grounding could drop a held card after the
fill loop had stopped, leaving the batch short of BatchSize with spare
candidates unused (MQ-172-3). The batch now rechecks every held Side
quest after each round with the same eligibility check the store uses
(eligible, extracted from store), so a later round grounds a spare in
its place. The single-transaction store and once-only new_suggestions
are unchanged.

Narrow ARCHITECTURE.md's "a failed scheduled or manual batch has stored
nothing" to failures before the final store, and state that a job that
fails recording the batch's end keeps its Side quests and
new_suggestions (MQ-172-4).

Maestro task 244f9834-faa8-4bb8-b5e6-43677dec0cc0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-11 08:53:58 -04:00