Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature 21 integration review remediation #183

Merged
approver_agent merged 2 commits from task/feature21-integration-fix_ac3dddf0-a05f-4e43-a5ad-3105fe6bdd95 into feature/446472d5-2a84-4aa2-bb37-fdc80815615c-home-dashboard 2026-10-10 19:17:33 -04:00
Conversation 2 Commits 2 Files Changed 22
+356 -60
dev_agent commented 2026-10-10 18:12:24 -04:00
Member
Copy Link
Copy Source

Maestro task ac3dddf0-a05f-4e43-a5ad-3105fe6bdd95.

Closes feature integration findings F21-01 (week-specific plan and Supply run URLs), F21-02 (keep a cached rotation card on refresh error), F21-03 (refetch Home at local midnight), and F21-04 (read-only pending Side quest count).

Does not merge pull request #181.

Maestro task ac3dddf0-a05f-4e43-a5ad-3105fe6bdd95. Closes feature integration findings F21-01 (week-specific plan and Supply run URLs), F21-02 (keep a cached rotation card on refresh error), F21-03 (refetch Home at local midnight), and F21-04 (read-only pending Side quest count). Does not merge pull request #181.
dev_agent added 1 commit 2026-10-10 18:12:25 -04:00
Fix Home dashboard integration findings (Feature 21)
CI / ci (pull_request) Successful in 8m27s
Details
CI / ci (push) Successful in 8m57s
Details
0a69efea5c 
- F21-01: plan_ready and list_ready links carry their week
  (/plan?week=, /plan/shopping?week=), and the Plan opens on ?week=
  and keeps it on the week shown, so an older update opens its week.
- F21-02: a failed refresh of the Rotation check shows its ErrorBanner
  beside the cached pending card instead of replacing it.
- F21-03: Home carries the household's timezone and is read again at
  its next local midnight.
- F21-04: Home counts pending Side quests through a read-only query
  (suggest.PendingCount), so reading Home never writes batches.

Task: ac3dddf0-a05f-4e43-a5ad-3105fe6bdd95

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent requested changes 2026-10-10 18:35:02 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
overseer added 1 commit 2026-10-10 18:36:20 -04:00
Find the actual next local midnight across clock changes (F21-03)
CI / ci (push) Successful in 9m4s
Details
CI / ci (pull_request) Successful in 8m11s
Details
d69852b045 
untilLocalMidnight subtracted the local clock time from 24 hours, so on a
23-hour spring-forward day Home refreshed an hour after midnight. It now
computes the instant the next calendar day starts in the household zone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 80338dd176 into feature/446472d5-2a84-4aa2-bb37-fdc80815615c-home-dashboard 2026-10-10 19:17:33 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#183