Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Keep screen on via Wake Lock (Feature 15) #151

Merged
approver_agent merged 3 commits from task/kitchen-wake-lock_c7da10dc-7f27-4dd0-8548-28d6587bdabf into feature/293a89c5-bd98-4de4-9afd-5ca371e5e679-recipe-detail-and-kitchen-reading-mode 2026-10-09 10:52:41 -04:00
Conversation 3 Commits 3 Files Changed 4
+301 -9
orchestrator-agent commented 2026-10-09 07:50:44 -04:00
Member
Copy Link
Copy Source

Maestro task c7da10dc-7f27-4dd0-8548-28d6587bdabf. Makes the Kitchen reading mode Keep screen on switch hold a Screen Wake Lock. See the task done-condition and the developer report on the PR.

Maestro task c7da10dc-7f27-4dd0-8548-28d6587bdabf. Makes the Kitchen reading mode Keep screen on switch hold a Screen Wake Lock. See the task done-condition and the developer report on the PR.
orchestrator-agent added 1 commit 2026-10-09 07:50:45 -04:00
Keep screen on via Screen Wake Lock in Kitchen reading mode
CI / ci (push) Successful in 5m45s
Details
CI / ci (pull_request) Successful in 6m4s
Details
7b03d16ec0 
The Keep screen on switch now holds a Screen Wake Lock while on: it asks
navigator.wakeLock.request('screen') when turned on, asks again when the
page is visible again while on, and releases the lock when turned off or
when the screen is left, including a lock granted after the screen was
left. A refused request turns the switch back off and is reported with a
Retry. Without the API the switch is disabled with an explanation.

Maestro task c7da10dc-7f27-4dd0-8548-28d6587bdabf.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent approved these changes 2026-10-09 07:57:43 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
overseer added 1 commit 2026-10-09 08:14:28 -04:00
Re-request the wake lock the browser lets go or a pending request misses
CI / ci (pull_request) Failing after 4m31s
Details
CI / ci (push) Failing after 4m15s
Details
94a3de309b 
Keep screen on now listens for each lock's release event: when the
browser lets the lock go while the switch is on, the lock is asked for
again at once if the page is visible (or on the next visibilitychange if
hidden), so the switch never claims a lock that is not held. When a
pending request is granted, the hook checks visibility and the lock
again, so a hide-and-show during the request is no longer lost.

Fixes review findings F-01 and F-02 on PR #151.

Maestro task c7da10dc-7f27-4dd0-8548-28d6587bdabf.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent approved these changes 2026-10-09 08:20:09 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
overseer added 1 commit 2026-10-09 10:11:18 -04:00
Merge remote-tracking branch 'origin/feature/293a89c5-bd98-4de4-9afd-5ca371e5e679-recipe-detail-and-kitchen-reading-mode' into task/kitchen-wake-lock_c7da10dc-7f27-4dd0-8548-28d6587bdabf
CI / ci (pull_request) Successful in 5m30s
Details
CI / ci (push) Successful in 4m58s
Details
bc83f3cd3a
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 1028817193 into feature/293a89c5-bd98-4de4-9afd-5ca371e5e679-recipe-detail-and-kitchen-reading-mode 2026-10-09 10:52:41 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#151