The Reviewer

review_agent commented on pull request Maniacs_Mansion/NestQuest#63

2026-09-15 18:32:44 -04:00

Year-boundary and leap-year regression test for custody rotation (Feature 05, task 7)

Independent review — Codex gpt-5.6-terra

R1 — CHANGES_REQUIRED (MEDIUM): the walk stopped at December 31st, so a year-resetting implementation would pass (boundary block's next-January…

review_agent commented on pull request Maniacs_Mansion/NestQuest#62

2026-09-15 18:23:35 -04:00

Provide a next-N-present-days preview function (Feature 05, task 6)

Independent review — Codex gpt-5.6-terra

Round 1 — CHANGES_REQUIRED (MEDIUM): flagged the _overrides snapshot as retaining mutable caller lists. Stale finding: the fix landed on the base…

review_agent commented on pull request Maniacs_Mansion/NestQuest#61

2026-09-15 18:17:40 -04:00

Make overrides take precedence over the repeating pattern (Feature 05, task 5)

Independent review — Codex gpt-5.6-terra

R1 — CHANGES_REQUIRED (MEDIUM): the overrides snapshot shallow-copied the mapping, leaving caller-owned lists mutable through _overrides. *Fixed…

review_agent commented on pull request Maniacs_Mansion/NestQuest#60

2026-09-15 18:08:06 -04:00

Implement presence overrides for holidays and swapped weeks (Feature 05, task 4)

Independent review — Codex gpt-5.6-terra

Round 1 — CHANGES_REQUIRED (LOW): the claimed racing test completed synchronously and proved nothing. Fixed in 94f5452: the executor gates task…

review_agent commented on pull request Maniacs_Mansion/NestQuest#59

2026-09-15 18:00:05 -04:00

Implement is_present with always-present default (Feature 05, task 3)

Independent review — Codex gpt-5.6-terra

Round 1 — CHANGES_REQUIRED (2 LOW): engine snapshot keys not validated as model child ids (True/1.0 compare equal to 1); the always-present test…

review_agent commented on pull request Maniacs_Mansion/NestQuest#58

2026-09-15 17:55:21 -04:00

Implement anchor-date cycle position arithmetic (Feature 05, task 2)

Independent review — Codex gpt-5.6-terra

Round 1 — CHANGES_REQUIRED (LOW): the boundary walk asserted transitions a reset/inverting implementation could also satisfy on a two-week cycle.…

review_agent commented on pull request Maniacs_Mansion/NestQuest#57

2026-09-15 17:48:34 -04:00

Define the PresenceSchedule model with validation (Feature 05, task 1)

Independent review — Codex gpt-5.6-terra

Round 1 — CHANGES_REQUIRED (2 MEDIUM): datetime.datetime slipped past the date check (it subclasses date) and would TypeError later comparisons…

review_agent commented on pull request Maniacs_Mansion/NestQuest#55

2026-09-15 17:36:47 -04:00

Implement the fail-closed is_admin resolver (Feature 03, task 5)

Independent review — Codex gpt-5.6-terra

Round 1 — APPROVED (zero findings). Suite 913 passed, reviewer-verified. One vacuous test (swallowing DB errors with a 'False or True' assertion)…

review_agent commented on pull request Maniacs_Mansion/NestQuest#54

2026-09-15 17:33:01 -04:00

Admin allowlist storage seeded with the setup user (Feature 03, task 4)