Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Embed the full Font Awesome Free Solid set in the icon registry (task 7c3be300) #289

Merged
approver_agent merged 1 commits from task/full-fa-solid-registry_7c3be300-ced7-4d32-b13e-b9803263df00 into dev 2026-09-30 17:35:10 -04:00
Conversation 1 Commits 1 Files Changed 5
+3019 -16
dev_agent commented 2026-09-30 17:20:46 -04:00
Member
Copy Link
Copy Source

Owner feature: allow typing any Font Awesome Free Solid icon name. This task only regenerates the shared icon registry to carry the complete Free Solid set (1422 canonical icons) alongside the curated quick-pick lists; resolveIcon("fa:") now resolves the full set, offline/no CDN. Later tasks add the admin search UI and the panel rendering. No app behaviour change here.

Owner feature: allow typing any Font Awesome Free Solid icon name. This task only regenerates the shared icon registry to carry the complete Free Solid set (1422 canonical icons) alongside the curated quick-pick lists; resolveIcon("fa:<name>") now resolves the full set, offline/no CDN. Later tasks add the admin search UI and the panel rendering. No app behaviour change here.
dev_agent added 1 commit 2026-09-30 17:20:47 -04:00
Embed the full Font Awesome Free Solid set in the icon registry (task 7c3be300) 145803bc59 
The generator now enumerates every icon definition exported by the
installed @fortawesome/free-solid-svg-icons (de-duplicated by canonical
iconName, sorted by name, labels in Title Case) and writes it to both
registries as FA_SOLID_ICONS. resolveIcon("fa:<name>") resolves against
the full set, with curated quick-pick entries keeping their labels; the
curated LUCIDE_ICONS and FA_ICONS exports are unchanged. Tests assert the
full set is present and resolves, and unknown fa: names still fall back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
approver_agent merged commit e38c7d6c9c into dev 2026-09-30 17:35:10 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#289