Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature review remediation: stale settings/clock docs after the timezone change #258

Merged
dev_agent merged 2 commits from task/settings-clock-docs_d1ce4976-43a2-4b49-9c1f-6ec2afe1fbea into feature/916210e7-8736-48da-9136-424731156f8c-ui-bugs 2026-09-26 10:11:21 -04:00
Conversation 1 Commits 2 Files Changed 3
+30 -23
dev_agent commented 2026-09-26 10:06:12 -04:00
Member
Copy Link
Copy Source

Task d1ce4976, feature-level remediation on 7adee7c. Resolves feature review F-001 (LOW): after the household-timezone change the docs still said 'ten settings' and described API household-day reads as host-local. Documentation-only correction in api/routes_admin.py and core/sweep.py: eleven fields including timezone (empty = host local), and the missed-sweep / occurrence-preview / sweep today reads are household-local via the configured timezone. No behavioural code change.

Evidence at e287c14: git diff --name-only = those two files only; grep finds no 'ten settings' or host-local-clock claim; TZ=UTC uv run pytest -q green; py_compile clean.

Task d1ce4976, feature-level remediation on 7adee7c. Resolves feature review F-001 (LOW): after the household-timezone change the docs still said 'ten settings' and described API household-day reads as host-local. Documentation-only correction in api/routes_admin.py and core/sweep.py: eleven fields including `timezone` (empty = host local), and the missed-sweep / occurrence-preview / sweep `today` reads are household-local via the configured timezone. No behavioural code change. Evidence at e287c14: git diff --name-only = those two files only; grep finds no 'ten settings' or host-local-clock claim; TZ=UTC uv run pytest -q green; py_compile clean.
dev_agent added 1 commit 2026-09-26 10:06:13 -04:00
Correct stale settings-count and API clock docstrings e287c145b0 
The household-timezone change added an eleventh setting (timezone) and
made the API's household-local dates derive from it. Update the admin
routes' settings, missed-sweep and occurrence-preview docstrings and
core/sweep.py's docstrings to say so (empty timezone falls back to
host local). Documentation only; no behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
overseer added 1 commit 2026-09-26 10:08:48 -04:00
Describe settings form test accurately: ten form fields, timezone is API-only 4e0474ef71 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit 4e6f9b339c into feature/916210e7-8736-48da-9136-424731156f8c-ui-bugs 2026-09-26 10:11:21 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#258