Fix quest-log meta line losing its class when not late #255

Member

Task d72dcbc1 (UI Bugs). The open quest card's meta span was built as class="meta ${meta.late ? "late" : nothing}"; Lit's nothing removes the whole class attribute when not late, so non-late meta lines lost the meta class/styling. Fix: class="${meta.late ? "meta late" : "meta"}"; bundle rebuilt; new jsdom test test_quest_log_meta_line_keeps_its_meta_class fails on the old bundle and asserts class="meta" / "meta late".

Evidence at 235c327: TZ=UTC uv run pytest -q = 2013 passed; frontend build ok; rebuild leaves the worktree clean.

Task d72dcbc1 (UI Bugs). The open quest card's meta span was built as `class="meta ${meta.late ? "late" : nothing}"`; Lit's `nothing` removes the whole class attribute when not late, so non-late meta lines lost the `meta` class/styling. Fix: `class="${meta.late ? "meta late" : "meta"}"`; bundle rebuilt; new jsdom test test_quest_log_meta_line_keeps_its_meta_class fails on the old bundle and asserts class="meta" / "meta late". Evidence at 235c327: TZ=UTC uv run pytest -q = 2013 passed; frontend build ok; rebuild leaves the worktree clean.
dev_agent added 1 commit 2026-09-26 09:40:17 -04:00
The open quest card built its meta line as
class="meta ${meta.late ? "late" : nothing}"; Lit drops the whole
attribute when any interpolated part is nothing, so every on-time quest
lost the meta class and its styling. Choose the full class string
instead, rebuild the panel bundle, and add a rendered regression test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit 87566689aa into feature/916210e7-8736-48da-9136-424731156f8c-ui-bugs 2026-09-26 09:42:29 -04:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#255