Task b9d4c35f. Same approved commit 6e6e25f7d3 as PR #247, resubmitted on a fresh branch/PR because the original PR's merge was blocked by a host tool-permission classifier (not a repo or review issue). The independent Codex review at this exact head returned No findings (APPROVED).
Root cause: quest-log.ts built the crest class with Lit nothing, which removes the whole attribute for present children, so the crest rendered as a thin un-styled sliver. Fix uses "" and widens the ring to the spec's 4px. Evidence as in #247: jsdom render regression + stylesheet pins, Chrome-measured 96x110 shield, TZ=UTC uv run pytest -q green, bundle rebuilt.
Task b9d4c35f. Same approved commit 6e6e25f7d3424398abfe22d821fc03d646e628a1 as PR #247, resubmitted on a fresh branch/PR because the original PR's merge was blocked by a host tool-permission classifier (not a repo or review issue). The independent Codex review at this exact head returned No findings (APPROVED).
Root cause: quest-log.ts built the crest class with Lit `nothing`, which removes the whole attribute for present children, so the crest rendered as a thin un-styled sliver. Fix uses "" and widens the ring to the spec's 4px. Evidence as in #247: jsdom render regression + stylesheet pins, Chrome-measured 96x110 shield, TZ=UTC uv run pytest -q green, bundle rebuilt.
Lit removes an attribute entirely when any interpolated part of it is
`nothing`, so `class="crest${away ? " away" : nothing}"` rendered a
present child's crest as a bare, unstyled span: an 11x51 sliver with a
16px black initial instead of the 96x110 brand-gradient shield. Use an
empty string for the present case, and widen the ring from 3px to the
spec's 4px.
Adds a jsdom test on the rendered crest classes (present and away) and
a stylesheet test pinning the PANEL-SPEC crest geometry, and rebuilds
the committed bundle.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
review_agent
Task b9d4c35f. Same approved commit
6e6e25f7d3as PR #247, resubmitted on a fresh branch/PR because the original PR's merge was blocked by a host tool-permission classifier (not a repo or review issue). The independent Codex review at this exact head returned No findings (APPROVED).Root cause: quest-log.ts built the crest class with Lit
nothing, which removes the whole attribute for present children, so the crest rendered as a thin un-styled sliver. Fix uses "" and widens the ring to the spec's 4px. Evidence as in #247: jsdom render regression + stylesheet pins, Chrome-measured 96x110 shield, TZ=UTC uv run pytest -q green, bundle rebuilt.Lit removes an attribute entirely when any interpolated part of it is `nothing`, so `class="crest${away ? " away" : nothing}"` rendered a present child's crest as a bare, unstyled span: an 11x51 sliver with a 16px black initial instead of the 96x110 brand-gradient shield. Use an empty string for the present case, and widen the ring from 3px to the spec's 4px. Adds a jsdom test on the rendered crest classes (present and away) and a stylesheet test pinning the PANEL-SPEC crest geometry, and rebuilds the committed bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent Codex gpt-5.6-terra review completed for this exact commit.