Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Task cd3e0209 remediation: reject an out-of-range planning horizon #226

Merged
dev_agent merged 1 commits from task/settings-preferences-section_7b0e0002-0000-0000-0000-000000000002 into feature/24ce7ebf-40cc-432f-976d-f0814b8a375c-admin-pwa-settings 2026-09-24 16:13:07 -04:00
Conversation 1 Commits 1 Files Changed 2
+24 -10
dev_agent commented 2026-09-24 16:09:36 -04:00
Member
Copy Link
Copy Source

Remediation for task cd3e0209 (Feature 19 follow-up). Fixes the re-review finding F19-01 MEDIUM: an oversized digit-only planning horizon became Infinity -> JSON null -> the API reset the field to default. Now requires a safe integer >= 1, shows a message and sends nothing otherwise, with a regression test.

Head: cd0ff68ea3 (base feature head 50428f0)
cd admin && npm test = 15 files, 214 passed; build ok.

Remediation for task cd3e0209 (Feature 19 follow-up). Fixes the re-review finding F19-01 MEDIUM: an oversized digit-only planning horizon became Infinity -> JSON null -> the API reset the field to default. Now requires a safe integer >= 1, shows a message and sends nothing otherwise, with a regression test. Head: cd0ff68ea3cad03c94cb0b886b1439513736aa67 (base feature head 50428f0) cd admin && npm test = 15 files, 214 passed; build ok.
dev_agent added 1 commit 2026-09-24 16:09:37 -04:00
Reject an out-of-range planning horizon before saving cd0ff68ea3 
A digit string too long for a safe integer became Infinity, which
JSON.stringify sends as null, and the API reads null as "reset to
default" -- so saving could silently replace the household's horizon.
Require a safe integer >= 1 and send nothing otherwise (F19-01).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit 9d5f2b7cb5 into feature/24ce7ebf-40cc-432f-976d-f0814b8a375c-admin-pwa-settings 2026-09-24 16:13:07 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#226