Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Task f50338c8: Fix the admin auth probe path and refusal state #212

Merged
dev_agent merged 1 commits from task/fix-the-admin-auth-probe-path-and-refusal-state_af11a2c1-0000-0000-0000-000000000001 into feature/24ce7ebf-40cc-432f-976d-f0814b8a375c-admin-pwa 2026-09-24 00:05:23 -04:00
Conversation 1 Commits 1 Files Changed 2
+164 -9
dev_agent commented 2026-09-24 00:02:50 -04:00
Member
Copy Link
Copy Source

Maestro task: f50338c8-8b48-4e3d-9064-e20d9b32fe34 (Feature 19 - Admin PWA). Addresses feature-review HIGH F-001.

The initial probe now calls GET /api/v1/admin/ping and only enters the shell on a 2xx; 403 -> refusal, 401 -> login, 404/500/network -> a clear error state (not the shell). Tests assert the path and each outcome.

Head: 0adaed553d
Base: feature/24ce7ebf-... @ 487bc00

Checks: cd admin && npm test = 14 files, 189 passed; npm run build exit 0.

Maestro task: f50338c8-8b48-4e3d-9064-e20d9b32fe34 (Feature 19 - Admin PWA). Addresses feature-review HIGH F-001. The initial probe now calls GET /api/v1/admin/ping and only enters the shell on a 2xx; 403 -> refusal, 401 -> login, 404/500/network -> a clear error state (not the shell). Tests assert the path and each outcome. Head: 0adaed553d8b22b80716fe733d542e00c5771223 Base: feature/24ce7ebf-... @ 487bc00 Checks: cd admin && npm test = 14 files, 189 passed; npm run build exit 0.
dev_agent added 1 commit 2026-09-24 00:02:51 -04:00
Probe /api/v1/admin/ping and refuse the shell on any non-OK outcome 0adaed553d 
The initial authorization probe called the nonexistent /api/v1/children
and treated every non-403 outcome as success, so a 404 rendered the
admin shell. Probe the admin plane's GET /api/v1/admin/ping instead and
enter the shell only on a 2xx: 403 shows the refusal, 401 keeps the
login flow, and any other status or network failure shows a new
probe-error screen with Retry and Sign out.

Task: f50338c8-8b48-4e3d-9064-e20d9b32fe34

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit 73782051aa into feature/24ce7ebf-40cc-432f-976d-f0814b8a375c-admin-pwa 2026-09-24 00:05:23 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#212