DAO layer for children and admin_users #18

2026-09-14T07:11:24-04:00

2026-09-14 07:11:24 -04:00

Adds dao_children.py: ChildrenDao (create, get, list_active, list_all, partial update, set_active, transactional reorder via staged negative offsets) and AdminUsersDao (idempotent add, remove, list, exists). All methods async, typed dataclass returns (ChildRecord, AdminUserRecord), all SQL confined to the module (guard test scans the package). No delete path for children per guardrail (deactivate only). 24 new tests; suite 348 passed.

orchestrator-agent added 1 commit 2026-09-14 07:11:25 -04:00

feat: add typed DAO layer for children and admin_users (#18 ) c5b4885cc0

overseer referenced this issue from a commit

2026-09-14 07:11:26 -04:00

feat: add typed DAO layer for children and admin_users (#18)

overseer added 1 commit 2026-09-14 07:14:33 -04:00

fix: address review findings - atomic admin add, reorder validation and serialization, honest rollback test, stronger SQL-leak guard f00ec03c78

- AdminUsersDao.add: single INSERT ON CONFLICT DO NOTHING (rowcount-derived
  result), race-safe; concurrent-add test with 5 racing coroutines
- ChildrenDao.reorder: rejects duplicate ids (ValueError); per-instance
  asyncio lock serializes concurrent reorders (the wrapper rejects
  concurrent transactions); rollback test now forces a real finalize-batch
  failure and asserts original order survives
- SQL-leak guard: scans package + tests with FROM/INTO/UPDATE/DELETE FROM/
  JOIN pattern; narrowly justified exclusions (schema DDL, migrations,
  their tests); this test file verified to contain no direct table SQL

overseer added 1 commit 2026-09-14 07:16:50 -04:00

fix: connection-scoped reorder serialization; recursive SQL-leak scan with span-exact self-exclusion 98e342df17

- reorder lock is now per-(connection, loop) via module-level registry
  shared by all ChildrenDao instances over one wrapper, matching the
  migration runner's approach; race test now uses two DAO instances on
  one connection
- SQL-leak guard scans recursively (rglob); self-scan excludes only the
  two guard functions' exact source spans via ast line numbers, so code
  anywhere else in the file is still scanned

overseer added 1 commit 2026-09-14 07:20:08 -04:00

test: exact-path SQL-leak allowlist; blob-mode self-scan catches multiline SQL 0fc3fbeed8

- leak guard allowlists repo-relative paths (not basenames) so a raw
  query in tests/nested/<name>.py cannot slip through
- self-scan removes only the guard functions' spans, then scans the
  remaining source as one blob with a pattern including standalone
  FROM/JOIN, so SQL split across physical lines is caught

overseer added 1 commit 2026-09-14 07:22:49 -04:00

test: fix self-scan UPDATE alternative and POSIX path joining df6285f3d7

- UPDATE pattern alternative corrected (UPDATE ... children, not
  UPDATE SET)
- allowlist comparison uses as_posix() so Windows separators cannot
  make the DAO itself appear as an offender

overseer added 1 commit 2026-09-14 07:24:58 -04:00

test: catch backtick and bracket-quoted table names in self-scan d8b16766e9

orchestrator-agent merged commit 43b20f2b12 into feature/8940567d-7b50-41ef-a510-8b234fe7290e-sqlite-data-layer

2026-09-14 07:26:34 -04:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#18