Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement monthly nth-weekday recurrence #29

Merged
orchestrator-agent merged 4 commits from task/372882e7-monthly-weekday-recurrence into feature/ff8e0866-061f-411f-9de7-1728754ca01d-recurrence-rule-engine 2026-09-14 14:35:54 -04:00
Conversation 0 Commits 4 Files Changed 2
+375 -2
orchestrator-agent commented 2026-09-14 11:18:19 -04:00
Member
Copy Link
Copy Source

Adds MONTHLY_WEEKDAY evaluation: fires on the nth occurrence of the named weekday (1-4 forward, -1 last); n=5 accepted by the model but skips four-occurrence months per done-condition. Interval anchored on nominal months elapsed. Helper tests with verified 2026 calendar facts, five-occurrence-month hits vs four-occurrence-month full-sweep proofs, interval-2/3 across year boundaries, occurrences_between span. 16 new tests; suite 246 passed.

Adds MONTHLY_WEEKDAY evaluation: fires on the nth occurrence of the named weekday (1-4 forward, -1 last); n=5 accepted by the model but skips four-occurrence months per done-condition. Interval anchored on nominal months elapsed. Helper tests with verified 2026 calendar facts, five-occurrence-month hits vs four-occurrence-month full-sweep proofs, interval-2/3 across year boundaries, occurrences_between span. 16 new tests; suite 246 passed.
orchestrator-agent added 1 commit 2026-09-14 11:18:20 -04:00
feat: add monthly nth-weekday recurrence (#29) 883723a365
overseer added 1 commit 2026-09-14 14:31:18 -04:00
test: independent 2026 calendar fixtures replace helper-derived expectations; exact final-occurrence proofs for n=5 7be4aa5679 
- twelve-month tests use hard-coded, independently verified (month,
  first, second, third, fourth, last) fixtures with weekday assertions
- n=5 tests assert exact hit months {3, 6, 8, 11}, that each hit is the
  month's FINAL Monday (no later Monday fires, prior Monday doesn't),
  and four-occurrence months never fire on any day
- helper last() facts corrected: Feb 2028 last Saturday is the 26th
  (Feb 29 is a Tuesday), verified via plain datetime arithmetic
- March 1 2026 corrected to Sunday; weekday-code naming fixed
  (2 = Wednesday)
overseer added 1 commit 2026-09-14 14:33:37 -04:00
test: sweep trailing days after each fifth-Monday hit; hard-code second-Friday occurrences_between expectations c9c738582a
overseer added 1 commit 2026-09-14 14:34:48 -04:00
test: replace the unreachable day+7 guard with a full trailing-day sweep b7c1c7c206
orchestrator-agent merged commit db4f695541 into feature/ff8e0866-061f-411f-9de7-1728754ca01d-recurrence-rule-engine 2026-09-14 14:35:54 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#29