Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Task b50b048f: Lucide icon picker (shipped subset) #205

Merged
dev_agent merged 1 commits from task/lucide-icon-picker-shipped-subset_b50b048f-40f6-418e-b571-ef6be3796296 into feature/24ce7ebf-40cc-432f-976d-f0814b8a375c-admin-pwa 2026-09-23 22:39:26 -04:00
Conversation 1 Commits 1 Files Changed 6
+348 -10
dev_agent commented 2026-09-23 22:37:02 -04:00
Member
Copy Link
Copy Source

Maestro task: b50b048f-40f6-418e-b571-ef6be3796296 (Feature 19 - Admin PWA).

Done condition: the definition edit sheet offers a Lucide icon picker backed by a shipped 24-40 glyph subset bundled locally (no CDN); the chosen icon persists on save and renders on the row; a test asserts the subset and the round-trip.

Head: 71982911f7
Base: feature/24ce7ebf-... @ 4b56e2f

Checks: cd admin && npm test = 9 files, 104 passed (2 runs); npm run build exit 0 (36 curated glyphs, ~7 kB gzip added, only imported icons in the bundle, no CDN URLs).

Maestro task: b50b048f-40f6-418e-b571-ef6be3796296 (Feature 19 - Admin PWA). Done condition: the definition edit sheet offers a Lucide icon picker backed by a shipped 24-40 glyph subset bundled locally (no CDN); the chosen icon persists on save and renders on the row; a test asserts the subset and the round-trip. Head: 71982911f71975058b862bc32c45a29fc2ce7310 Base: feature/24ce7ebf-... @ 4b56e2f Checks: cd admin && npm test = 9 files, 104 passed (2 runs); npm run build exit 0 (36 curated glyphs, ~7 kB gzip added, only imported icons in the bundle, no CDN URLs).
dev_agent added 1 commit 2026-09-23 22:37:03 -04:00
Add Lucide icon picker to the definition edit sheet 71982911f7 
Ship a curated 36-glyph household subset via named lucide-react imports
(bundled, no CDN), offer it as a grid picker in the edit sheet, send the
chosen icon in create and edit bodies, and render it on the list row
with a generic fallback for no icon or an unknown legacy value.

Task b50b048f-40f6-418e-b571-ef6be3796296

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit a22f990bd6 into feature/24ce7ebf-40cc-432f-976d-f0814b8a375c-admin-pwa 2026-09-23 22:39:26 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#205