Maniacs_Mansion/NestQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Task 2e96585c: Definitions list and edit sheet #198

Merged
dev_agent merged 2 commits from task/definitions-list-and-edit-sheet_2e96585c-ca63-413d-bf99-7e203c39ddde into feature/24ce7ebf-40cc-432f-976d-f0814b8a375c-admin-pwa 2026-09-23 21:26:28 -04:00
Conversation 1 Commits 2 Files Changed 9
+2385 -1
dev_agent commented 2026-09-23 21:17:36 -04:00
Member
Copy Link
Copy Source

Maestro task: 2e96585c-ca63-413d-bf99-7e203c39ddde (Feature 19 - Admin PWA).

Done condition: the Definitions list shows definitions (title, assignees, recurrence, windows; inactive styled) with filter chips; the edit sheet provides multi-select assignees, a recurrence rule with interval, per-window due times, multi-select windows and a skip-on-away toggle; saving calls POST/PATCH and the change is visible on reload.

Head: 5a28fddfe2
Base: feature/24ce7ebf-... @ dbe873e (dev 4b39af4 merged in)

Checks: cd admin && npm test = 9 files, 85 passed; npm run build exit 0. Icon picker and occurrence preview are separate tasks. Inactive children are omitted from submitted assignees (API rejects them).

Maestro task: 2e96585c-ca63-413d-bf99-7e203c39ddde (Feature 19 - Admin PWA). Done condition: the Definitions list shows definitions (title, assignees, recurrence, windows; inactive styled) with filter chips; the edit sheet provides multi-select assignees, a recurrence rule with interval, per-window due times, multi-select windows and a skip-on-away toggle; saving calls POST/PATCH and the change is visible on reload. Head: 5a28fddfe285a96cdab9ae253c9393bfeec77f02 Base: feature/24ce7ebf-... @ dbe873e (dev 4b39af4 merged in) Checks: cd admin && npm test = 9 files, 85 passed; npm run build exit 0. Icon picker and occurrence preview are separate tasks. Inactive children are omitted from submitted assignees (API rejects them).
dev_agent added 1 commit 2026-09-23 21:17:37 -04:00
Add admin Definitions list and edit sheet 5a28fddfe2 
Tasks tab lists quest definitions (assignees · recurrence · windows,
inactive rows, per-child filter chips) and a bottom edit sheet with
multi-select assignees, repeats + interval, per-window due times,
multi-select windows and a skip-on-away toggle. Saving POSTs or PATCHes
the admin quest-definition routes and re-fetches the list; 403 and 422
responses are shown in the sheet.

Task: 2e96585c-ca63-413d-bf99-7e203c39ddde

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
overseer added 1 commit 2026-09-23 21:22:28 -04:00
Preserve inactive assignees on edit and manage edit-sheet focus bf00b63215 
NQ-198-001: a PATCH omits assignee_child_ids while the active selection is
unchanged, so inactive assignees survive unrelated edits. Changing the
selection when inactive children would be dropped asks for confirmation
first. Inactive assignees are shown locked in the picker with a hint.

NQ-198-002: the edit sheet moves focus in on open, wraps Tab/Shift+Tab,
restores focus to the trigger on close, and cancels on Escape when not
saving.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit 33d8e0d2ac into feature/24ce7ebf-40cc-432f-976d-f0814b8a375c-admin-pwa 2026-09-23 21:26:28 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#198