Implement the versioned migration runner #17

2026-09-14T06:54:47-04:00

2026-09-14 06:54:47 -04:00

Adds migrations.py: nestquest_schema_version metadata table, ordered append-only MIGRATIONS list (migration 1 = full v1 DDL), apply_migrations() applying each pending migration's statements plus its version stamp inside ONE transaction (DELETE+INSERT stamp so fresh files stamp correctly), read_schema_version(), future-version downgrade guard, no-op path that opens no write transaction (verified byte-identical main file). 17 tests incl. rollback atomicity, retry-after-fix, resume-from-partial, non-integer version guard. Suite 316 passed.

orchestrator-agent added 1 commit 2026-09-14 06:54:47 -04:00

feat: add versioned schema migration runner (#17 ) c6d42e8277

overseer referenced this issue from a commit

2026-09-14 06:54:48 -04:00

feat: add versioned schema migration runner (#17)

overseer added 1 commit 2026-09-14 06:59:33 -04:00

fix: address review findings - startup wiring, singleton version table, version guards 492c1149f0

- __init__.py now calls apply_migrations() on setup instead of raw DDL
  (HIGH finding: the runner was never invoked at startup); lifecycle
  wiring tests in test_migrations.py cover fresh migrate, reload reuse,
  and close-on-failure
- VERSION_TABLE DDL enforces singleton row (id=1 PRIMARY KEY + CHECK)
  and version >= 1; stamp is INSERT .. ON CONFLICT DO UPDATE keyed on
  the singleton row
- read_schema_version rejects non-integer and sub-1 versions with
  explicit guards (bool excluded)
- no-op test asserts content hash + mtime, not just size

overseer added 1 commit 2026-09-14 07:01:52 -04:00

test: hash WAL alongside main db in no-op test; exercise unload+setup reload lifecycle a679004720

overseer added 1 commit 2026-09-14 07:05:15 -04:00

fix: re-read schema version inside each migration transaction; spy on close in setup-failure test c0c540c194

- apply_migrations re-reads the version under the transaction lock
  before applying, so two interleaved runners on one connection cannot
  both apply a non-idempotent migration from a stale read
- setup-failure test now spies on NestQuestDatabase.close and asserts
  it ran and no runtime record was stored (was vacuous)

overseer added 1 commit 2026-09-14 07:07:49 -04:00

fix: serialize concurrent migration runners with a per-connection lock f27c84488d

NestQuestDatabase rejects a second transaction while one is active, so
two concurrent apply_migrations callers on one connection crashed with
RuntimeError instead of queueing. apply_migrations now holds a
per-(connection, loop) asyncio lock across the whole decide-and-apply
span; the queued runner re-reads the stamped version and applies
nothing. Deterministic concurrent-runner regression test added.

orchestrator-agent merged commit 2c8c90a24e into feature/8940567d-7b50-41ef-a510-8b234fe7290e-sqlite-data-layer

2026-09-14 07:10:23 -04:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#17