Correct remaining Home Assistant-derived timezone comments (task e9aa78f3)

The CONF_TIMEZONE comment claimed the integration always uses Home
Assistant's time_zone and ignores the field; it actually relays the
API's effective application timezone. Also reword two materialize.py
docstrings that described the household date as HA-derived.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

RELEASE_NOTES.md

@@ -1,69 +1,5 @@
 # NestQuest Release Notes
 
-## Version 0.9.8 — 2026-09-30
-
-### Scope
-
-Owner-directed change: the application's timezone is now **manual-only and
-admin-authoritative**. Nothing sets it automatically any more; an admin sets it
-from the admin app, and the saved value is the single source of local time for
-the whole application. This reverses the automatic Home Assistant zone adoption
-shipped in 0.9.6 and the admin app's browser-zone auto-set, and supersedes
-decision D-018 with D-019. (PRs #282, #283, #285, #286; feature
-`a3cd8e27` "Manual application timezone control".)
-
-### Behaviour
-
-- **No automatic timezone setting.** Removed: the API's adoption of Home
-  Assistant's reported zone (the `X-NestQuest-Timezone` request header and the
-  `adopt_reported_timezone` path), the integration's reporting of
-  `hass.config.time_zone`, the admin app's browser-zone auto-detect and
-  automatic save, and the `timezone_configured` marker.
-- **The admin sets it manually**, in the admin app's Preferences: a curated IANA
-  zone picker plus a free "Other IANA zone" entry, with an explicit choice for
-  empty ("API host local time"). Nothing is auto-filled or auto-saved.
-- **The saved value is authoritative across the whole application**: the panel
-  snapshot's overdue/today derivation, both panel cards' dates and clocks,
-  completion timestamps, the missed-sweep scheduler, and the admin reads all use
-  it. The API publishes the effective zone (`api/host_zone.effective_timezone`:
-  the saved value, else the API host's own zone) on the panel snapshot and the
-  admin settings response, so the panel and admin app render in the same zone.
-- **The kids' panel now follows the application zone, not the browser.** This
-  supersedes the panel-local overdue behaviour from 0.9.7; a quest is overdue
-  when the application clock says so, not when the panel device's clock does.
-- **An admin save of the timezone or the day-rollover time re-plans the running
-  missed-sweep scheduler.**
-- The integration tolerates an API snapshot without the timezone field, so the
-  integration and the API may be upgraded in either order.
-
-### Requirements
-
-- Home Assistant floor 2024.6.0 (unchanged).
-
-### Breaking changes
-
-- None to the database. The schema is unchanged at version 9: no migration and
-  no database backup is required for this release.
-- Behavioural reversal: if a timezone had been auto-set by 0.9.6–0.9.7, the
-  stored value persists after upgrading (it is simply no longer changed
-  automatically), so no action is needed unless a different zone is wanted.
-- With no timezone saved, the API host's local zone applies (UTC on the standard
-  deployment). Set the timezone in the admin Preferences for correct
-  household-local behaviour. A previously auto-set value counts as saved and
-  will be kept.
-
-### Known limitations
-
-- If no timezone has been saved, the API host zone applies; on the standard
-  UTC-host deployment, overdue and day boundaries will be wrong until an admin
-  sets the zone.
-- The admin app's timezone picker replaces any zone outside its curated list via
-  the "Other IANA zone" entry; the value is validated as an IANA name.
-
-### Rollback
-
-- No schema change: rolling back to 0.9.7 requires no database restore.
-
 ## Version 0.9.7 — 2026-09-29
 
 ### Scope

admin/src/icons/registry.test.ts

@@ -3,14 +3,7 @@ import { join } from "node:path";
 import { describe, expect, it } from "vitest";
 // The offline generator is the only writer of both registry artefacts.
 import { OUTPUT_PATHS, REPO_ROOT, SOURCE_PATH, renderRegistry } from "../../../tools/icons/generate.mjs";
-import {
-  EMOJI_MAX_CODE_POINTS,
-  FALLBACK_ICON,
-  FA_ICONS,
-  FA_SOLID_ICONS,
-  LUCIDE_ICONS,
-  resolveIcon,
-} from "./registry.generated";
+import { EMOJI_MAX_CODE_POINTS, FALLBACK_ICON, FA_ICONS, LUCIDE_ICONS, resolveIcon } from "./registry.generated";
 
 type Curated = { lucide: { name: string; label: string }[]; fa: { name: string; label: string }[] };
 
@@ -52,18 +45,7 @@ describe("shared icon registry — one source of truth", () => {
       expect(icon.viewBox).toMatch(/^0 0 \d+ 512$/);
       expect(icon.paths.length, icon.name).toBeGreaterThan(0);
     }
-    const solidNames = FA_SOLID_ICONS.map((icon) => icon.name);
-    expect(solidNames.length).toBeGreaterThanOrEqual(1400);
-    expect(solidNames).toEqual([...solidNames].sort());
-    expect(new Set(solidNames).size).toBe(solidNames.length);
-    for (const { name } of FA_ICONS) expect(solidNames, name).toContain(name);
-    for (const icon of FA_SOLID_ICONS) {
-      expect(icon.kind).toBe("fa");
-      expect(icon.key).toBe(`fa:${icon.name}`);
-      expect(icon.viewBox).toMatch(/^0 0 \d+ 512$/);
-      expect(icon.paths.length, icon.name).toBeGreaterThan(0);
-    }
-    for (const icon of [...LUCIDE_ICONS, ...FA_ICONS, ...FA_SOLID_ICONS]) {
+    for (const icon of [...LUCIDE_ICONS, ...FA_ICONS]) {
       for (const d of icon.paths) expect(d, icon.key).toMatch(/^[Mm][-0-9.,\sA-Za-z]+$/);
     }
   });
@@ -79,12 +61,6 @@ describe("resolveIcon", () => {
     expect(broom.kind).toBe("fa");
     expect(broom).toBe(FA_ICONS.find((icon) => icon.name === "broom"));
 
-    // Any Free Solid name resolves, not just the curated quick-pick set.
-    const rocket = resolveIcon("fa:rocket");
-    expect(rocket).toBe(FA_SOLID_ICONS.find((icon) => icon.name === "rocket"));
-    expect(rocket).toMatchObject({ kind: "fa", key: "fa:rocket", label: "Rocket" });
-    expect(resolveIcon("fa:person-dress-burst")).toMatchObject({ kind: "fa", label: "Person Dress Burst" });
-
     expect(resolveIcon("emoji:🐶")).toEqual({ kind: "emoji", key: "emoji:🐶", text: "🐶" });
     expect(resolveIcon("emoji:👨‍👩‍👧")).toEqual({ kind: "emoji", key: "emoji:👨‍👩‍👧", text: "👨‍👩‍👧" });
   });

custom_components/nestquest/manifest.json

@@ -15,5 +15,5 @@
   "iot_class": "local_polling",
   "issue_tracker": "https://github.com/Maniacs-Mansion/NestQuest/issues",
   "requirements": [],
-  "version": "0.9.8"
+  "version": "0.9.7"
 }

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "nestquest"
-version = "0.9.8"
+version = "0.9.7"
 description = "NestQuest Home Assistant Integration"
 readme = "README.md"
 requires-python = ">=3.11"

tests/test_icon_registry.py

@@ -63,75 +63,6 @@ def test_artefacts_carry_exactly_the_curated_names_and_labels() -> None:
     assert 15 <= len(curated["fa"]) <= 25
 
 
-def test_artefacts_carry_the_full_font_awesome_free_solid_set() -> None:
-    text = ARTEFACTS[0].read_text(encoding="utf-8")
-    solid = _generated_set(text, "FA_SOLID_ICONS")
-    names = [entry["name"] for entry in solid]
-    assert names == sorted(names)
-    assert len(set(names)) == len(names)
-    # The complete Free Solid set, not a curated pick (7.x ships ~1,400).
-    assert len(solid) >= 1400
-    for entry in solid:
-        assert set(entry) == {"kind", "key", "name", "label", "viewBox", "paths"}
-        assert entry["kind"] == "fa"
-        assert entry["key"] == f"fa:{entry['name']}"
-        assert entry["label"] == " ".join(
-            part[0].upper() + part[1:] for part in entry["name"].split("-")
-        )
-        assert re.fullmatch(r"0 0 \d+ \d+", entry["viewBox"])
-        assert entry["paths"] and all(entry["paths"])
-    # A well-known glyph, a barely-known one, and every curated quick-pick.
-    assert {"rocket", "mug-hot", "person-dress-burst"} <= set(names)
-    assert {e["name"] for e in _curated()["fa"]} <= set(names)
-    assert "rocket-ship-9000" not in names
-
-
-def test_resolve_icon_resolves_any_free_solid_name() -> None:
-    node = shutil.which("node")
-    if node is None:
-        pytest.skip("needs node")
-    script = (
-        "const m = await import(process.argv[1]);"
-        "const out = {};"
-        "for (const v of JSON.parse(process.argv[2])) {"
-        " const r = m.resolveIcon(v); out[v] = [r.kind, r.label ?? null]; }"
-        "console.log(JSON.stringify(out));"
-    )
-    values = [
-        "fa:rocket",
-        "fa:mug-hot",
-        "fa:person-dress-burst",
-        "fa:paw",
-        "fa:rocket-ship-9000",
-        "fa:Rocket",
-        "fa:",
-        "lucide:dog",
-        "dog",
-        "lucide:rocket",
-    ]
-    result = subprocess.run(
-        [node, "--input-type=module", "-e", script,
-         ARTEFACTS[0].as_uri(), json.dumps(values)],
-        cwd=REPO_ROOT,
-        capture_output=True,
-        text=True,
-        check=False,
-    )
-    if result.returncode != 0 and "Unknown file extension" in result.stderr:
-        pytest.skip("node cannot strip TypeScript types (needs Node 22.18+)")
-    assert result.returncode == 0, result.stderr
-    resolved = json.loads(result.stdout)
-    assert resolved["fa:rocket"] == ["fa", "Rocket"]
-    assert resolved["fa:mug-hot"] == ["fa", "Mug Hot"]
-    assert resolved["fa:person-dress-burst"] == ["fa", "Person Dress Burst"]
-    # Curated entries keep their quick-pick label.
-    assert resolved["fa:paw"] == ["fa", "Pets"]
-    assert resolved["lucide:dog"][0] == "lucide"
-    assert resolved["dog"][0] == "lucide"
-    for unknown in ("fa:rocket-ship-9000", "fa:Rocket", "fa:", "lucide:rocket"):
-        assert resolved[unknown] == ["fallback", None], unknown
-
-
 def test_registry_has_no_remote_url_cdn_or_lucide_runtime() -> None:
     for path in (SOURCE, GENERATOR, *ARTEFACTS):
         text = path.read_text(encoding="utf-8")

tests/test_panel_cards.py

@@ -1431,26 +1431,6 @@ def test_open_quest_tile_falls_back_to_the_star() -> None:
         assert tile["icon"] is None
 
 
-def test_open_quest_tile_renders_any_free_solid_icon() -> None:
-    """A Font Awesome Free Solid name outside the curated quick-pick list
-    still renders its glyph from the shipped bundle; an unknown ``fa:`` name
-    keeps the star."""
-    tiles = _quest_log_tiles(
-        [
-            _quest_row(1, "fa:rocket"),
-            _quest_row(2, "fa:mug-hot"),
-            _quest_row(3, "fa:definitely-not-an-icon"),
-        ]
-    )
-    for instance_id, key in ((1, "fa:rocket"), (2, "fa:mug-hot")):
-        assert tiles[instance_id]["icon"] == key
-        assert tiles[instance_id]["fill"] == "currentColor"
-        assert tiles[instance_id]["paths"] > 0
-        assert not tiles[instance_id]["star"]
-    assert tiles[3]["star"]
-    assert tiles[3]["icon"] is None
-
-
 def test_sealed_quest_tile_keeps_the_star() -> None:
     """A sealed card keeps its star tile (and its wax seal) whatever the
     definition's icon; only the open card shows the quest's icon."""

tools/icons/generate.mjs

@@ -2,10 +2,9 @@
  * Offline generator for the shared quest-icon registry.
  *
  * Reads the curated names + labels in `curated-icons.json` (the one source of
- * truth for the quick-pick lists), pulls each glyph's SVG path data from
- * locally installed packages in `admin/node_modules` (lucide-react and
- * @fortawesome/free-solid-svg-icons — no network), and writes the same
- * TypeScript module into both bundles:
+ * truth), pulls each glyph's SVG path data from locally installed packages in
+ * `admin/node_modules` (lucide-react and @fortawesome/free-solid-svg-icons —
+ * no network), and writes the same TypeScript module into both bundles:
  *
  *   admin/src/icons/registry.generated.ts
  *   frontend/src/icons/registry.generated.ts
@@ -15,14 +14,6 @@
  *
  * Lucide circles, rects and lines are converted to path `d` strings so every
  * glyph is plain `{ viewBox, paths }` data any renderer can draw.
- *
- * Besides the curated sets, the module embeds the complete Font Awesome Free
- * Solid set (`FA_SOLID_ICONS`). Its source is the installed
- * @fortawesome/free-solid-svg-icons package itself: every exported icon
- * definition, de-duplicated by canonical `iconName` (the package also exports
- * each legacy alias, e.g. faHome for `house`, as the same definition). The
- * package carries no human labels, so each label is the kebab name in Title
- * Case (`spray-can-sparkles` → "Spray Can Sparkles").
  */
 import { readFileSync, writeFileSync, mkdirSync } from "node:fs";
 import { createRequire } from "node:module";
@@ -98,37 +89,6 @@ function faExportName(name) {
   return "fa" + name.split("-").map((part) => part[0].toUpperCase() + part.slice(1)).join("");
 }
 
-function faGlyph(definition, label) {
-  const { iconName: name } = definition;
-  const [width, height, , , pathData] = definition.icon;
-  const paths = Array.isArray(pathData) ? pathData.filter(Boolean) : [pathData];
-  return { kind: "fa", key: `fa:${name}`, name, label, viewBox: `0 0 ${width} ${height}`, paths };
-}
-
-function titleCase(name) {
-  return name.split("-").map((part) => part[0].toUpperCase() + part.slice(1)).join(" ");
-}
-
-/** Every Free Solid glyph, one per canonical name, sorted by name. */
-function allSolidGlyphs(faPackage) {
-  const byName = new Map();
-  for (const definition of Object.values(faPackage)) {
-    if (!definition || typeof definition !== "object" || !Array.isArray(definition.icon)) continue;
-    if (definition.prefix !== "fas") throw new Error(`fa ${definition.iconName}: unexpected prefix ${definition.prefix}`);
-    const name = definition.iconName;
-    if (!/^[a-z0-9](?:[a-z0-9-]*[a-z0-9])?$/.test(name)) throw new Error(`fa ${name}: not a kebab name`);
-    const seen = byName.get(name);
-    if (seen && JSON.stringify(seen.icon) !== JSON.stringify(definition.icon)) {
-      throw new Error(`fa ${name}: two exports disagree on the glyph`);
-    }
-    byName.set(name, definition);
-  }
-  if (byName.size === 0) throw new Error("fa: no icons found in @fortawesome/free-solid-svg-icons");
-  return [...byName.keys()]
-    .sort((a, b) => (a < b ? -1 : a > b ? 1 : 0))
-    .map((name) => faGlyph(byName.get(name), titleCase(name)));
-}
-
 function checkCurated(list, namespace) {
   const seen = new Set();
   for (const { name, label } of list) {
@@ -156,9 +116,11 @@ async function buildEntries() {
   for (const { name, label } of curated.fa) {
     const definition = faPackage[faExportName(name)];
     if (!definition || definition.iconName !== name) throw new Error(`fa ${name}: not in @fortawesome/free-solid-svg-icons`);
-    fa.push(faGlyph(definition, label));
+    const [width, height, , , pathData] = definition.icon;
+    const paths = Array.isArray(pathData) ? pathData.filter(Boolean) : [pathData];
+    fa.push({ kind: "fa", key: `fa:${name}`, name, label, viewBox: `0 0 ${width} ${height}`, paths });
   }
-  return { lucide, fa, faSolid: allSolidGlyphs(faPackage) };
+  return { lucide, fa };
 }
 
 const RESOLVER = `
@@ -168,10 +130,7 @@ export const FALLBACK_ICON: FallbackIcon = { kind: "fallback", key: null };
 export const EMOJI_MAX_CODE_POINTS = 8;
 
 const LUCIDE_BY_NAME: ReadonlyMap<string, GlyphIcon> = new Map(LUCIDE_ICONS.map((icon) => [icon.name, icon]));
-/** The full Free Solid set, with each curated entry (and its quick-pick label) taking precedence. */
-const FA_BY_NAME: ReadonlyMap<string, GlyphIcon> = new Map(
-  [...FA_SOLID_ICONS, ...FA_ICONS].map((icon) => [icon.name, icon]),
-);
+const FA_BY_NAME: ReadonlyMap<string, GlyphIcon> = new Map(FA_ICONS.map((icon) => [icon.name, icon]));
 
 function isEmojiPayload(text: string): boolean {
   const codePoints = [...text];
@@ -183,8 +142,7 @@ function isEmojiPayload(text: string): boolean {
  * The renderable icon for a stored definition \`icon\` value.
  *
  * \`lucide:<name>\` and a legacy bare \`<name>\` resolve against the curated
- * Lucide set, \`fa:<name>\` against the full Font Awesome Free Solid set
- * (curated entries keep their quick-pick labels), and
+ * Lucide set, \`fa:<name>\` against the curated Font Awesome set, and
  * \`emoji:<grapheme>\` to its text. Like the backend's
  * normalize_icon_for_read, nothing here throws: null, empty, an unknown
  * namespace or name, or a malformed emoji all resolve to FALLBACK_ICON.
@@ -204,7 +162,7 @@ export function resolveIcon(value: string | null | undefined): ResolvedIcon {
 
 /** The generated module's full text (identical for both bundles). */
 export async function renderRegistry() {
-  const { lucide, fa, faSolid } = await buildEntries();
+  const { lucide, fa } = await buildEntries();
   const source = relative(REPO_ROOT, SOURCE_PATH);
   return `// GENERATED by tools/icons/generate.mjs from ${source} — do not edit.
 // Regenerate with \`node tools/icons/generate.mjs\` (the drift tests fail if this
@@ -244,13 +202,7 @@ export type ResolvedIcon = GlyphIcon | EmojiIcon | FallbackIcon;
 
 export const LUCIDE_ICONS: readonly GlyphIcon[] = ${JSON.stringify(lucide, null, 2)};
 
-/** The curated Font Awesome quick-pick set. */
 export const FA_ICONS: readonly GlyphIcon[] = ${JSON.stringify(fa, null, 2)};
-
-/** Every Font Awesome Free Solid glyph (${faSolid.length}), sorted by name; one entry per line. */
-export const FA_SOLID_ICONS: readonly GlyphIcon[] = [
-${faSolid.map((icon) => JSON.stringify(icon)).join(",\n")}
-];
 ${RESOLVER}`;
 }
 

uv.lock

@@ -373,7 +373,7 @@ wheels = [
 
 [[package]]
 name = "nestquest"
-version = "0.9.8"
+version = "0.9.7"
 source = { virtual = "." }
 
 [package.dev-dependencies]