Feature 19 follow-up: calendar week starts on Sunday (#230)

Co-authored-by: dev_agent <17+dev_agent@code.cubecraftcreations.com> Co-committed-by: dev_agent <17+dev_agent@code.cubecraftcreations.com>
2026-09-24 19:33:22 -04:00
parent 5650a1f5a2
commit d3c52974f5
6 changed files with 74 additions and 8 deletions
@@ -362,6 +362,39 @@ describe("DefinitionsTab", () => {
    expect(screen.getByText("4 definitions · 3 children")).toBeTruthy();
  });

+  it("the weekday picker lists Sunday first and Sunday still stores 6", async () => {
+    vi.useFakeTimers({ toFake: ["Date"] });
+    vi.setSystemTime(new Date(2026, 8, 23, 9, 0)); // Wed 23 Sep 2026, local
+    await renderReady();
+
+    fireEvent.click(screen.getByRole("button", { name: "New" }));
+    const s = sheet();
+    fireEvent.change(within(s).getByRole("textbox", { name: "Title" }), {
+      target: { value: "Feed the cat" },
+    });
+    fireEvent.click(within(s).getByRole("button", { name: /Assigned children/ }));
+    fireEvent.click(within(s).getByRole("checkbox", { name: "Declan" }));
+    fireEvent.change(within(s).getByRole("combobox", { name: "Repeats" }), {
+      target: { value: "weekly" },
+    });
+
+    const days = within(s).getByRole("group", { name: "Days" });
+    expect(
+      within(days)
+        .getAllByRole("button")
+        .map((b) => b.getAttribute("aria-label")),
+    ).toEqual(["Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"]);
+    fireEvent.click(within(days).getByRole("button", { name: "Sunday" }));
+    fireEvent.click(within(s).getByRole("button", { name: "Evening" }));
+
+    await act(async () => {
+      fireEvent.click(within(s).getByRole("button", { name: "Save changes" }));
+    });
+    const body = api.writes()[0].body as { rule: DefinitionRule };
+    expect(body.rule.weekday_set).toEqual([2, 6]);
+    expect(meta(await screen.findByTestId("definition-99"))).toContain("on Sun, Wed");
+  });
+
  it("tapping a row opens the sheet in editing state and saving PATCHes", async () => {
    await renderReady();
    const row = screen.getByTestId("definition-11");