Feature 19 follow-up: calendar week starts on Sunday (#230)

Co-authored-by: dev_agent <17+dev_agent@code.cubecraftcreations.com>
Co-committed-by: dev_agent <17+dev_agent@code.cubecraftcreations.com>

admin/src/definitions/DefinitionsTab.test.tsx

@@ -362,6 +362,39 @@ describe("DefinitionsTab", () => {
     expect(screen.getByText("4 definitions · 3 children")).toBeTruthy();
   });
 
+  it("the weekday picker lists Sunday first and Sunday still stores 6", async () => {
+    vi.useFakeTimers({ toFake: ["Date"] });
+    vi.setSystemTime(new Date(2026, 8, 23, 9, 0)); // Wed 23 Sep 2026, local
+    await renderReady();
+
+    fireEvent.click(screen.getByRole("button", { name: "New" }));
+    const s = sheet();
+    fireEvent.change(within(s).getByRole("textbox", { name: "Title" }), {
+      target: { value: "Feed the cat" },
+    });
+    fireEvent.click(within(s).getByRole("button", { name: /Assigned children/ }));
+    fireEvent.click(within(s).getByRole("checkbox", { name: "Declan" }));
+    fireEvent.change(within(s).getByRole("combobox", { name: "Repeats" }), {
+      target: { value: "weekly" },
+    });
+
+    const days = within(s).getByRole("group", { name: "Days" });
+    expect(
+      within(days)
+        .getAllByRole("button")
+        .map((b) => b.getAttribute("aria-label")),
+    ).toEqual(["Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"]);
+    fireEvent.click(within(days).getByRole("button", { name: "Sunday" }));
+    fireEvent.click(within(s).getByRole("button", { name: "Evening" }));
+
+    await act(async () => {
+      fireEvent.click(within(s).getByRole("button", { name: "Save changes" }));
+    });
+    const body = api.writes()[0].body as { rule: DefinitionRule };
+    expect(body.rule.weekday_set).toEqual([2, 6]);
+    expect(meta(await screen.findByTestId("definition-99"))).toContain("on Sun, Wed");
+  });
+
   it("tapping a row opens the sheet in editing state and saving PATCHes", async () => {
     await renderReady();
     const row = screen.getByTestId("definition-11");

admin/src/definitions/DefinitionsTab.tsx

@@ -27,6 +27,7 @@ import {
 } from "../api/definitions";
 import {
   MONTH_SHORT,
+  WEEKDAY_DISPLAY_ORDER,
   WEEKDAY_SHORT,
   WINDOW_LABELS,
   WINDOW_ORDER,
@@ -680,9 +681,9 @@ function EditSheet({
             </div>
             {draft.repeats === "weekly" || draft.repeats === "custom" ? (
               <div className="defs-weekdays" role="group" aria-label="Days">
-                {WEEKDAY_SHORT.map((label, day) => (
+                {WEEKDAY_DISPLAY_ORDER.map((day) => (
                   <button
-                    key={label}
+                    key={day}
                     type="button"
                     aria-pressed={draft.weekdays.includes(day)}
                     aria-label={WEEKDAY_LONG[day]}
@@ -691,7 +692,7 @@ function EditSheet({
                     }
                     onClick={() => update({ weekdays: toggle(draft.weekdays, day) })}
                   >
-                    {label.charAt(0)}
+                    {WEEKDAY_SHORT[day].charAt(0)}
                   </button>
                 ))}
               </div>

admin/src/definitions/format.ts

@@ -21,6 +21,9 @@ export const WINDOW_LABELS: Record<WindowName, string> = {
 /** Index 0 = Monday .. 6 = Sunday, the core's weekday numbering. */
 export const WEEKDAY_SHORT = ["Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"];
 
+/** Display order for a week: Sunday first. The stored indices stay Monday=0. */
+export const WEEKDAY_DISPLAY_ORDER = [6, 0, 1, 2, 3, 4, 5];
+
 export const MONTH_SHORT = [
   "Jan", "Feb", "Mar", "Apr", "May", "Jun",
   "Jul", "Aug", "Sep", "Oct", "Nov", "Dec",
@@ -51,7 +54,7 @@ export function assigneeSummary(
 
 function weekdayList(days: number[] | null): string {
   return [...(days ?? [])]
-    .sort((a, b) => a - b)
+    .sort((a, b) => WEEKDAY_DISPLAY_ORDER.indexOf(a) - WEEKDAY_DISPLAY_ORDER.indexOf(b))
     .map((day) => WEEKDAY_SHORT[day])
     .join(", ");
 }