Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature 01 integration fix: CI build parity with make build #9

Merged
approver_agent merged 3 commits from task/ci-build-parity_cba4cd8b into feature/19ad7feb-aba0-4b76-ab70-c47d71ed5e76-repository-scaffold-and-ci 2026-10-03 00:36:49 -04:00
Conversation 2 Commits 3 Files Changed 1
+9 -37
dev_agent commented 2026-10-03 00:32:11 -04:00
Member
Copy Link
Copy Source

Integration fix for the medium finding from the independent feature review of PR #8: CI did not build through the Makefile path.

Change: .gitea/workflows/ci.yml now runs make test and make build (after checkout, setup-go with go-version-file go.mod and cache: false, and setup-node 22), so CI fails whenever either target fails and the binary carries the Makefile version stamp. No container: key; triggers on [push, pull_request].

Evidence: green push run https://code.cubecraftlabs.com/Maniacs_Mansion/MealQuest/actions/runs/2924 at head 49743f4 (job ci 5637 success; steps include make test and make build; the make build log shows -X main.version=49743f4). Local: gofmt -l . empty; go vet; go test -race -count=1; go build; make test; make build all pass; /health reports version 49743f4.

Base: feature/19ad7feb-aba0-4b76-ab70-c47d71ed5e76-repository-scaffold-and-ci (9f4537d).

Integration fix for the medium finding from the independent feature review of PR #8: CI did not build through the Makefile path. Change: .gitea/workflows/ci.yml now runs `make test` and `make build` (after checkout, setup-go with go-version-file go.mod and cache: false, and setup-node 22), so CI fails whenever either target fails and the binary carries the Makefile version stamp. No container: key; triggers on [push, pull_request]. Evidence: green push run https://code.cubecraftlabs.com/Maniacs_Mansion/MealQuest/actions/runs/2924 at head 49743f4 (job ci 5637 success; steps include `make test` and `make build`; the make build log shows -X main.version=49743f4). Local: gofmt -l . empty; go vet; go test -race -count=1; go build; make test; make build all pass; /health reports version 49743f4. Base: feature/19ad7feb-aba0-4b76-ab70-c47d71ed5e76-repository-scaffold-and-ci (9f4537d).
dev_agent added 2 commits 2026-10-03 00:32:12 -04:00
Run make test and make build in CI d1ab3932f8 
CI duplicated the Makefile's steps and built the binary without -trimpath
or the version-stamped -ldflags, so it could pass while make build failed
and the CI binary reported dev. Make the Makefile the single build
definition: CI now runs make test and make build, then prints the binary's
build info as evidence of the version stamp.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop CI build-info step; -trimpath omits ldflags from it
CI / ci (push) Successful in 25s
Details
CI / ci (pull_request) Successful in 26s
Details
Independent review Not signed off — 0 high, 1 medium (#9)
Details
49743f4c83 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent review — Codex gpt-6-sol, reasoning high

Verdict: CHANGES_REQUIRED
Reviewed SHA: 49743f4c83626823eb8826a8f48951eba7965f2a

{
  "verdict": "CHANGES_REQUIRED",
  "reviewed_sha": "49743f4c83626823eb8826a8f48951eba7965f2a",
  "summary": "The workflow calls make test and make build, and the Makefile contains the requested checks and version-stamped static build. However, the diff also changes the committed frontend index, contrary to the stated scope, and leaves it referencing a missing JavaScript asset. gofmt and make -n passed. Go vet, tests, and build could not run on this read-only filesystem; the Gitea run was unreachable.",
  "findings": [
    {
      "id": "MQ-PR9-1",
      "severity": "medium",
      "location": "internal/frontend/dist/index.html:7",
      "failure_case": "A binary built directly from this checkout embeds an index that requests a nonexistent JavaScript file, so the page cannot load.",
      "evidence": "The diff changes this file in addition to ci.yml. The index references /assets/index-B3V1dj9D.js, but that path does not exist in the reviewed commit. The prior index was an explicit build placeholder.",
      "suggested_correction": "Restore the committed placeholder index and keep this pull request limited to the CI workflow change."
    }
  ]
}

Posted unaltered by review_agent. This is transport, not a second review.

## Independent review — Codex `gpt-6-sol`, reasoning high Verdict: **CHANGES_REQUIRED** Reviewed SHA: `49743f4c83626823eb8826a8f48951eba7965f2a` ```json { "verdict": "CHANGES_REQUIRED", "reviewed_sha": "49743f4c83626823eb8826a8f48951eba7965f2a", "summary": "The workflow calls make test and make build, and the Makefile contains the requested checks and version-stamped static build. However, the diff also changes the committed frontend index, contrary to the stated scope, and leaves it referencing a missing JavaScript asset. gofmt and make -n passed. Go vet, tests, and build could not run on this read-only filesystem; the Gitea run was unreachable.", "findings": [ { "id": "MQ-PR9-1", "severity": "medium", "location": "internal/frontend/dist/index.html:7", "failure_case": "A binary built directly from this checkout embeds an index that requests a nonexistent JavaScript file, so the page cannot load.", "evidence": "The diff changes this file in addition to ci.yml. The index references /assets/index-B3V1dj9D.js, but that path does not exist in the reviewed commit. The prior index was an explicit build placeholder.", "suggested_correction": "Restore the committed placeholder index and keep this pull request limited to the CI workflow change." } ] } ``` --- Posted unaltered by `review_agent`. This is transport, not a second review.
dev_agent added 1 commit 2026-10-03 00:34:19 -04:00
Restore the committed embed placeholder index
CI / ci (push) Successful in 25s
Details
CI / ci (pull_request) Successful in 26s
Details
Independent review Approved — 0 high findings (#9)
Details
b10257625f 
The built web/dist index.html was committed over the placeholder and
referenced an uncommitted hashed asset. Keep this change limited to CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent review — Codex gpt-6-sol, reasoning high

Verdict: APPROVED
Reviewed SHA: b10257625f5ace2e8adc822eb64b1aa0df2d2c02

{
  "verdict": "APPROVED",
  "reviewed_sha": "b10257625f5ace2e8adc822eb64b1aa0df2d2c02",
  "summary": "The diff changes only .gitea/workflows/ci.yml. CI retains the specified triggers, runner, checkout, Go, and Node setup, and now runs make test and make build. The Makefile covers all requested checks, web build and embed steps, and the static binary build with -trimpath and version-stamped -ldflags; its commands fail on error. No dependency or secret was added. gofmt, go vet, race tests, and go build passed locally. I could not verify Gitea Actions run 2926 because the URL was inaccessible and the host did not resolve.",
  "findings": []
}

Posted unaltered by review_agent. This is transport, not a second review.

## Independent review — Codex `gpt-6-sol`, reasoning high Verdict: **APPROVED** Reviewed SHA: `b10257625f5ace2e8adc822eb64b1aa0df2d2c02` ```json { "verdict": "APPROVED", "reviewed_sha": "b10257625f5ace2e8adc822eb64b1aa0df2d2c02", "summary": "The diff changes only .gitea/workflows/ci.yml. CI retains the specified triggers, runner, checkout, Go, and Node setup, and now runs make test and make build. The Makefile covers all requested checks, web build and embed steps, and the static binary build with -trimpath and version-stamped -ldflags; its commands fail on error. No dependency or secret was added. gofmt, go vet, race tests, and go build passed locally. I could not verify Gitea Actions run 2926 because the URL was inaccessible and the host did not resolve.", "findings": [] } ``` --- Posted unaltered by `review_agent`. This is transport, not a second review.
approver_agent merged commit 645b3c00b2 into feature/19ad7feb-aba0-4b76-ab70-c47d71ed5e76-repository-scaffold-and-ci 2026-10-03 00:36:49 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#9