Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Household settings screen #84

Merged
approver_agent merged 2 commits from task/household-settings-screen_48f8b8c3-7d5c-415d-9a61-980dc065bb90 into feature/b28d9979-0f7a-4e81-bdff-2f16f3db2053-settings-admin-ai 2026-10-06 11:25:14 -04:00
Conversation 2 Commits 2 Files Changed 12
+1315 -93
dev_agent commented 2026-10-06 11:07:32 -04:00
Member
Copy Link
Copy Source

Maestro task: 48f8b8c3-7d5c-415d-9a61-980dc065bb90 (Feature 11 - Settings Home and Admin AI Assistant).

Done-condition

/settings/household lets the household view and edit: timezone (searchable IANA list with the current offset shown), dinner time, day-of reminder time, rotation check time ("When we ask whether to keep a new dinner", default 9:00 am the day after), plan-draft day/time, suggestions day/time and Chat autosend day/time, with plain-word copy and the note "Changes apply to everyone". Saving PATCHes /api/v1/settings/household and shows validation errors inline. Vitest covers load, edit + save payload, validation error display and the unsaved-changes guard. Typecheck, test and build pass.

Evidence

  • New /settings/household screen wired to GET/PATCH /api/v1/settings/household; PATCH sends only changed fields; API errors render inline and as whole-form errors; unsaved-changes guard; searchable IANA timezone list with current offset.
  • lint:colors, typecheck, test, build pass; gofmt -l . empty; route test added.
  • Headless Chrome at 390px with a mock API: changing Chicago + plan-draft day + dinner 18:15 sent exactly {"timezone":"America/Chicago","dinner_time":"18:15","plan_draft_dow":4}; clearing a time showed the inline error; the leave guard appeared.

Not tested against the real Go server (needs sign-in).

Maestro task: 48f8b8c3-7d5c-415d-9a61-980dc065bb90 (Feature 11 - Settings Home and Admin AI Assistant). ## Done-condition /settings/household lets the household view and edit: timezone (searchable IANA list with the current offset shown), dinner time, day-of reminder time, rotation check time ("When we ask whether to keep a new dinner", default 9:00 am the day after), plan-draft day/time, suggestions day/time and Chat autosend day/time, with plain-word copy and the note "Changes apply to everyone". Saving PATCHes /api/v1/settings/household and shows validation errors inline. Vitest covers load, edit + save payload, validation error display and the unsaved-changes guard. Typecheck, test and build pass. ## Evidence - New /settings/household screen wired to GET/PATCH /api/v1/settings/household; PATCH sends only changed fields; API errors render inline and as whole-form errors; unsaved-changes guard; searchable IANA timezone list with current offset. - lint:colors, typecheck, test, build pass; gofmt -l . empty; route test added. - Headless Chrome at 390px with a mock API: changing Chicago + plan-draft day + dinner 18:15 sent exactly {"timezone":"America/Chicago","dinner_time":"18:15","plan_draft_dow":4}; clearing a time showed the inline error; the leave guard appeared. Not tested against the real Go server (needs sign-in).
dev_agent added 1 commit 2026-10-06 11:07:32 -04:00
Add the household settings screen
CI / ci (push) Successful in 1m55s
Details
CI / ci (pull_request) Successful in 2m0s
Details
85d3c1684a 
/settings/household edits the time zone (a searchable IANA list with each
zone's current UTC offset), dinner time, day-of reminder, rotation check,
and the plan draft, new suggestions and Google Chat Supply run day and
time, with plain-word copy for each and "Changes apply to everyone in the
household." Save PATCHes only the changed fields; the API's
invalid_settings problems show under their fields. The leave guard and
confirm sheet move out of the AI settings page so both screens share them.

Maestro task 48f8b8c3-7d5c-415d-9a61-980dc065bb90.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
overseer added 1 commit 2026-10-06 11:07:32 -04:00
Add the household settings screen
CI / ci (push) Successful in 1m55s
Details
CI / ci (pull_request) Successful in 2m0s
Details
85d3c1684a 
/settings/household edits the time zone (a searchable IANA list with each
zone's current UTC offset), dinner time, day-of reminder, rotation check,
and the plan draft, new suggestions and Google Chat Supply run day and
time, with plain-word copy for each and "Changes apply to everyone in the
household." Save PATCHes only the changed fields; the API's
invalid_settings problems show under their fields. The leave guard and
confirm sheet move out of the AI settings page so both screens share them.

Maestro task 48f8b8c3-7d5c-415d-9a61-980dc065bb90.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent requested changes 2026-10-06 11:09:23 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
overseer added 1 commit 2026-10-06 11:17:21 -04:00
Offer the UTC zones and the saved zone in the time zone picker
CI / ci (push) Successful in 1m57s
Details
CI / ci (pull_request) Successful in 2m0s
Details
6e01f4e069 
Intl.supportedValuesOf('timeZone') lists only canonical zones, so UTC,
Etc/UTC, GMT and Etc/GMT, which the server accepts, could not be chosen.
Merge them into the list, and keep the saved zone listed after another
is chosen so an alias such as US/Eastern can be chosen back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 8654b6bcee into feature/b28d9979-0f7a-4e81-bdff-2f16f3db2053-settings-admin-ai 2026-10-06 11:25:14 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#84