Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

schema.org Recipe JSON-LD extractor #66

Merged
approver_agent merged 2 commits from task/jsonld-extractor_4c4570be-e0d2-43ad-90ea-0a4a9eeeb0b9 into feature/cebed295-8c05-453b-807b-8078dcd8d250-recipe-grounding 2026-10-05 13:13:04 -04:00
Conversation 2 Commits 2 Files Changed 11
+1207 -1
dev_agent commented 2026-10-05 12:50:48 -04:00
Member
Copy Link
Copy Source

Maestro task: 4c4570be-e0d2-43ad-90ea-0a4a9eeeb0b9 (Feature 10 - Recipe Grounding and Photos).

Done-condition

internal/recipes Extract(html, url) finds application/ld+json scripts and returns the Recipe node handling @graph, top-level arrays, @type string/array, image string/ImageObject/array (largest, absolute URL), recipeIngredient strings, recipeInstructions as string/HowToStep/HowToSection (flattened in order), ISO-8601 prep/cook/total -> minutes (total derived when absent), recipeYield, site name (publisher/og:site_name/host). testdata/ has >=6 trimmed real pages from different sites incl. HowToSection and @graph; table tests assert title/image/ingredients/steps/minutes and ErrNoRecipe. Go quality floor passes.

Evidence

  • internal/recipes extractor + fixtures; gofmt/vet/go test -race/build pass; no new dependency.
  • Note: some real fixtures (Allrecipes, Serious Eats) returned 403 when fetched; @type-array and relative-image shapes are covered by hand-written pages.
Maestro task: 4c4570be-e0d2-43ad-90ea-0a4a9eeeb0b9 (Feature 10 - Recipe Grounding and Photos). ## Done-condition internal/recipes Extract(html, url) finds application/ld+json scripts and returns the Recipe node handling @graph, top-level arrays, @type string/array, image string/ImageObject/array (largest, absolute URL), recipeIngredient strings, recipeInstructions as string/HowToStep/HowToSection (flattened in order), ISO-8601 prep/cook/total -> minutes (total derived when absent), recipeYield, site name (publisher/og:site_name/host). testdata/ has >=6 trimmed real pages from different sites incl. HowToSection and @graph; table tests assert title/image/ingredients/steps/minutes and ErrNoRecipe. Go quality floor passes. ## Evidence - internal/recipes extractor + fixtures; gofmt/vet/go test -race/build pass; no new dependency. - Note: some real fixtures (Allrecipes, Serious Eats) returned 403 when fetched; @type-array and relative-image shapes are covered by hand-written pages.
dev_agent added 1 commit 2026-10-05 12:50:49 -04:00
Add schema.org Recipe JSON-LD extractor
CI / ci (push) Successful in 1m35s
Details
CI / ci (pull_request) Successful in 1m37s
Details
9e05d16a46 
recipes.Extract(page, url) scans a page's application/ld+json scripts and
og:site_name with a small targeted scanner (no new dependency) and returns
the single Recipe node: top level, top-level array or @graph, @type as a
string or array. It picks the largest image and resolves it against the
page URL, flattens HowToStep/HowToSection instructions in order, converts
ISO-8601 durations to minutes (total derived from prep + cook when absent),
and names the site from publisher, og:site_name or host. No Recipe is
ErrNoRecipe; two is ErrManyRecipes; shapes schema.org does not allow,
such as a "20 minutes" cookTime, are ErrMalformedRecipe.

testdata holds trimmed real pages from BBC Good Food, Budget Bytes,
RecipeTin Eats (HowToSection), King Arthur Baking, Delish (top-level
array), Food.com, Bon Appétit (non-ISO duration) and a Budget Bytes page
with no Recipe.

Maestro task 4c4570be-e0d2-43ad-90ea-0a4a9eeeb0b9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
overseer added 1 commit 2026-10-05 12:50:49 -04:00
Add schema.org Recipe JSON-LD extractor
CI / ci (push) Successful in 1m35s
Details
CI / ci (pull_request) Successful in 1m37s
Details
9e05d16a46 
recipes.Extract(page, url) scans a page's application/ld+json scripts and
og:site_name with a small targeted scanner (no new dependency) and returns
the single Recipe node: top level, top-level array or @graph, @type as a
string or array. It picks the largest image and resolves it against the
page URL, flattens HowToStep/HowToSection instructions in order, converts
ISO-8601 durations to minutes (total derived from prep + cook when absent),
and names the site from publisher, og:site_name or host. No Recipe is
ErrNoRecipe; two is ErrManyRecipes; shapes schema.org does not allow,
such as a "20 minutes" cookTime, are ErrMalformedRecipe.

testdata holds trimmed real pages from BBC Good Food, Budget Bytes,
RecipeTin Eats (HowToSection), King Arthur Baking, Delish (top-level
array), Food.com, Bon Appétit (non-ISO duration) and a Budget Bytes page
with no Recipe.

Maestro task 4c4570be-e0d2-43ad-90ea-0a4a9eeeb0b9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent requested changes 2026-10-05 12:54:27 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
overseer added 1 commit 2026-10-05 13:02:05 -04:00
Resolve JSON-LD @id references, accept schema.org type IRIs, refuse empty durations
CI / ci (push) Successful in 1m36s
Details
CI / ci (pull_request) Successful in 1m36s
Details
48338a0c3d 
Review findings on the Recipe extractor:

- An image or publisher given as an {"@id": ...} reference now resolves to
  the node with that @id at a script's top level, in a top-level array or
  in an @graph, in any of the page's scripts. An image reference no node
  has, or one naming two nodes, is ErrMalformedRecipe; an unresolved
  publisher falls through to og:site_name and the host as before.
- @type matches the term or the absolute https:// or http://schema.org IRI,
  as a string or in an array, for Recipe, HowToStep and HowToSection.
- A present but empty or blank prepTime, cookTime or totalTime is an invalid
  ISO-8601 duration (ErrMalformedRecipe); an absent or null one is still
  nil.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit ec5b586c16 into feature/cebed295-8c05-453b-807b-8078dcd8d250-recipe-grounding 2026-10-05 13:13:04 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#66