Web app manifest and icons #50

Member

Task 58b74786-937a-45a5-850f-7913273beba2.

vite-plugin-pwa in injectManifest mode, manifest MealQuest standalone, icons derived from design/logos/logo_v1_2Oct2026.jpg, minimal src/sw.ts. Service worker registers only in production builds. Head 46cc7500de.

Task 58b74786-937a-45a5-850f-7913273beba2. vite-plugin-pwa in injectManifest mode, manifest MealQuest standalone, icons derived from design/logos/logo_v1_2Oct2026.jpg, minimal src/sw.ts. Service worker registers only in production builds. Head 46cc7500de1f95d9bea9038cc385f18f81c521f3.
dev_agent added 1 commit 2026-10-04 16:13:08 -04:00
Add the web app manifest, icons and service worker via vite-plugin-pwa
CI / ci (push) Successful in 1m34s
Independent review Codex gpt-6-sol high: APPROVED (0 findings)
CI / ci (pull_request) Successful in 1m36s
46cc7500de
vite-plugin-pwa runs in injectManifest mode over a minimal src/sw.ts that
caches the injected precache list on install. The manifest lives in
web/manifest.json (MealQuest, standalone at /, Grape theme over the page
background) with 192, 512 and maskable 512 PNG icons and a 180 px
apple-touch-icon, all generated from design/logos/logo_v1_2Oct2026.jpg by
web/scripts/generate-icons.py.

The plugin links the manifest and adds the registerSW.js script only in
production builds. src/pwa.test.ts builds and previews the app to assert
the shipped manifest, sw.js, icon sizes and registration, and checks that
the dev server registers nothing.

Maestro task: 58b74786-937a-45a5-850f-7913273beba2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member

Independent review — Codex gpt-6-sol, reasoning high

Verdict: APPROVED
Reviewed SHA: 46cc7500de1f95d9bea9038cc385f18f81c521f3

{
  "verdict": "APPROVED",
  "reviewed_sha": "46cc7500de1f95d9bea9038cc385f18f81c521f3",
  "summary": "The diff meets the stated manifest and service worker requirements. All four committed PNGs have the required dimensions and are derived from the specified logo. The service worker only precaches build assets; no auth or settings responses are cached. vite-plugin-pwa is the only new direct dependency, and lint:colors passes. node_modules is absent, so I did not install packages or run typecheck, tests, or build.",
  "findings": []
}

Posted unaltered by review_agent. This is transport, not a second review.

## Independent review — Codex `gpt-6-sol`, reasoning high Verdict: **APPROVED** Reviewed SHA: `46cc7500de1f95d9bea9038cc385f18f81c521f3` ```json { "verdict": "APPROVED", "reviewed_sha": "46cc7500de1f95d9bea9038cc385f18f81c521f3", "summary": "The diff meets the stated manifest and service worker requirements. All four committed PNGs have the required dimensions and are derived from the specified logo. The service worker only precaches build assets; no auth or settings responses are cached. vite-plugin-pwa is the only new direct dependency, and lint:colors passes. node_modules is absent, so I did not install packages or run typecheck, tests, or build.", "findings": [] } ``` --- Posted unaltered by `review_agent`. This is transport, not a second review.
approver_agent merged commit dd58865323 into feature/ea4f47b4-6f1e-4735-a33e-6e91bf092564-pwa-shell 2026-10-04 16:16:43 -04:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#50