Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Serve the MealQuest favicon instead of the browser default (Maestro 7c778111) #213

Merged
approver_agent merged 1 commits from task/favicon_7c778111-c615-4437-a3f6-0e36bcb97e63 into feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness 2026-10-12 09:34:26 -04:00
Conversation 1 Commits 1 Files Changed 7
+111 -9
orchestrator-agent commented 2026-10-12 09:24:01 -04:00
Member
Copy Link
Copy Source

Maestro task 7c778111-c615-4437-a3f6-0e36bcb97e63.

Browsers showed the default/Authentik favicon because index.html had no icon links. Generates favicon.ico + PNG sizes from the v1 logo (design/logos, read-only) into web/public, links them in index.html, precaches them in the service worker, and adds a Vitest check for the links. Matches the existing PWA icon generation pattern.

Maestro task 7c778111-c615-4437-a3f6-0e36bcb97e63. Browsers showed the default/Authentik favicon because index.html had no icon links. Generates favicon.ico + PNG sizes from the v1 logo (design/logos, read-only) into web/public, links them in index.html, precaches them in the service worker, and adds a Vitest check for the links. Matches the existing PWA icon generation pattern.
orchestrator-agent added 1 commit 2026-10-12 09:24:01 -04:00
Serve the MealQuest favicon instead of the browser default (Maestro 7c778111)
CI / ci (push) Successful in 10m2s
Details
CI / ci (pull_request) Successful in 9m58s
Details
bcc9e56749 
index.html linked only the apple-touch-icon, so browsers fell back to a
default favicon. generate-icons now also writes favicon.ico (16/32/48
PNG-in-ICO) and 16/32 px PNG favicons from the v1 logo; index.html links
them, and the service worker precaches every icon and favicon so the
offline shell keeps them (the glob covers the manifest icons, so the
plugin no longer injects them a second time).

pwa.test.ts asserts the build ships the favicons at the right sizes,
links them from index.html, and precaches each icon exactly once.

Task: 7c778111-c615-4437-a3f6-0e36bcb97e63

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 48c4c0e6f1 into feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness 2026-10-12 09:34:26 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#213