Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enforce unique recipe item positions per recipe (Maestro 75bb8cc1) #198

Merged
approver_agent merged 4 commits from task/recipe-item-positions_75bb8cc1-fd30-4050-90d2-a1627a865b22 into feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness 2026-10-11 15:29:59 -04:00
Conversation 2 Commits 4 Files Changed 8
+130 -55
orchestrator-agent commented 2026-10-11 08:58:24 -04:00
Member
Copy Link
Copy Source

Maestro task 75bb8cc1-fd30-4050-90d2-a1627a865b22.

Adds migration 0018 with unique (recipe_id, position) constraints on recipe_ingredients and recipe_steps, removes the read-time guard so the detail read relies on position alone, and adds regression tests for duplicate rejection and migration failure on existing duplicate data (fail fast). Run the documented duplicate check against production before deploying.

Maestro task 75bb8cc1-fd30-4050-90d2-a1627a865b22. Adds migration 0018 with unique (recipe_id, position) constraints on recipe_ingredients and recipe_steps, removes the read-time guard so the detail read relies on position alone, and adds regression tests for duplicate rejection and migration failure on existing duplicate data (fail fast). Run the documented duplicate check against production before deploying.
orchestrator-agent added 1 commit 2026-10-11 08:58:25 -04:00
Enforce unique recipe item positions per recipe
CI / ci (push) Successful in 9m17s
Details
CI / ci (pull_request) Successful in 8m10s
Details
da4f048f85 
Add migration 0018 with unique indexes on recipe_ingredients and
recipe_steps (recipe_id, position), so a recipe can never hold two
ingredients or two steps at one position. The dinner detail read now
orders by position alone and drops its read-time duplicate check; a
database already holding a duplicate fails the migration.

Maestro task 75bb8cc1-fd30-4050-90d2-a1627a865b22

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
overseer added 1 commit 2026-10-11 10:35:30 -04:00
Merge remote-tracking branch 'origin/feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness' into task/recipe-item-positions_75bb8cc1-fd30-4050-90d2-a1627a865b22
CI / ci (push) Successful in 8m14s
Details
CI / ci (pull_request) Successful in 8m13s
Details
161365fade
overseer added 1 commit 2026-10-11 11:52:54 -04:00
Document the pre-deploy duplicate position check for migration 0018 (Maestro 75bb8cc1)
CI / ci (pull_request) Successful in 8m11s
Details
CI / ci (push) Successful in 8m10s
Details
3dda308f30 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent approved these changes 2026-10-11 12:09:43 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
overseer added 1 commit 2026-10-11 15:12:34 -04:00
Merge the feature branch into task/recipe-item-positions (Maestro 75bb8cc1 refresh)
CI / ci (push) Successful in 8m18s
Details
CI / ci (pull_request) Successful in 8m17s
Details
807b1a0184 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 9d91686c35 into feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness 2026-10-11 15:29:59 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#198