Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Empty, loading and error state sweep #187

Merged
approver_agent merged 2 commits from task/empty-loading-error-sweep_322a15db-b2ad-46f4-a2ba-cb3745dd0aff into feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness 2026-10-10 23:00:13 -04:00
Conversation 2 Commits 2 Files Changed 2
+651
orchestrator-agent commented 2026-10-10 22:10:46 -04:00
Member
Copy Link
Copy Source

Maestro task 322a15db-b2ad-46f4-a2ba-cb3745dd0aff.

Adds docs/STATES.md and a Vitest sweep of loading, empty, and error states. Head: 832e6b9f7d.

Maestro task 322a15db-b2ad-46f4-a2ba-cb3745dd0aff. Adds docs/STATES.md and a Vitest sweep of loading, empty, and error states. Head: 832e6b9f7d44b56f6d65bd06807ab2e6e08d4799.
orchestrator-agent added 1 commit 2026-10-10 22:10:47 -04:00
Document and test every route's empty, loading and error states
CI / ci (push) Successful in 8m10s
Details
CI / ci (pull_request) Successful in 8m15s
Details
832e6b9f7d 
docs/STATES.md lists each handoff route and the added Settings screens
with its empty, loading and error state, all built on Skeleton,
ErrorBanner and EmptyState. web/src/states.test.tsx renders the three
variants of every route against a stubbed API, asserting the copy and
pressing Retry.

Task: 322a15db-b2ad-46f4-a2ba-cb3745dd0aff

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent requested changes 2026-10-10 22:32:57 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
overseer added 1 commit 2026-10-10 22:35:42 -04:00
Scope settings loading tests to their section and document onboarding paths
CI / ci (push) Successful in 8m8s
Details
CI / ci (pull_request) Successful in 8m11s
Details
9a183c1984 
The /settings/notifications and /settings/ai loading tests passed on any
skeleton, including the webhook and Recipe search cards' own. They now
wait for those sections to settle and check the one skeleton left sits
before them, so removing the held section's skeleton fails the test.

docs/STATES.md listed /onboarding as the Regulars step. It now lists the
Welcome (/onboarding), Regulars (/onboarding/regulars) and Notifications
(/onboarding/notifications) steps, each tested at its own path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 25edb6fb26 into feature/7383c2cb-3179-4b45-b558-bf1bc1833fad-launch-readiness 2026-10-10 23:00:13 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#187