Withhold unsafe recipe sources from idea job results (BASE-01) #170

Merged

approver_agent merged 2 commits from task/ideas-source-safety_c15ed4b5-25ae-43c6-8d36-f4a6dd51e5af into dev 2026-10-09 19:04:45 -04:00

Conversation 3 Commits 2 Files Changed 10

+399 -94

2 Commits

Author	SHA1	Message	Date
dev_agentandClaude Opus 5.5	c961d65092	Show idea job results' sources safely on every read ... GET /jobs/{id} served a succeeded idea job's stored result as it was, so a result stored before sources were made safe still showed a token-bearing source_url and a site_name taken from the link's host (BASE-01-R1). jobs.Kind.FailedResult becomes ShownResult, applied to every stored result with the job's status: ideas_from_ingredients and quick_ideas results show no ideas when failed and, otherwise, each idea's source through dinners.SourceOf, the one rule, so no job old or new serves an unsafe source. Other kinds' results are untouched. dinners.SourceOf now parses the link before reading the site name, so a link that does not parse is an error with or without a stored name, and an idea job grounded in one fails instead of succeeding (BASE-01-R2). Task: c15ed4b5-25ae-43c6-8d36-f4a6dd51e5af Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-09 18:33:57 -04:00
dev_agentandClaude Opus 5.5	1eafe812ec	Withhold unsafe recipe sources from idea job results ... Cook from what I have and Quick dinners ideas returned the grounded recipe's raw source_url and site_name, so a link carrying a token in its query or userinfo, or a stored name taken from its host, reached the client in the job response (BASE-01). dinners.SourceOf is now the one way a fetched recipe's source reaches a client: the dinner detail and both idea result builders use it. An idea's source_url and site_name are null when they could leak a secret, and a source that does not parse fails the job instead of being shown. Task: c15ed4b5-25ae-43c6-8d36-f4a6dd51e5af Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-09 18:07:21 -04:00