Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Web Push sender (Feature 19) #164

Merged
approver_agent merged 1 commits from task/push-sender_32a1a4ad-9221-46de-8468-3ffce19b108c into feature/bbd91ead-1e2b-48fb-b577-fa0a3faf5842-notifications-web-push-and-google-chat 2026-10-09 13:45:21 -04:00
Conversation 1 Commits 1 Files Changed 8
+910
orchestrator-agent commented 2026-10-09 13:19:25 -04:00
Member
Copy Link
Copy Source

Maestro task 32a1a4ad-9221-46de-8468-3ffce19b108c. internal/push implements the notify push-channel sender over SherClockHolmes/webpush-go: sends {title,body,url,tag} with TTL 12h to every subscription, records last_success_at, increments failure_count, deletes 404/410 subscriptions, and reports sent when at least one device succeeded (no subscriptions = sent with a note). See the task done-condition and the developer report on the PR.

Maestro task 32a1a4ad-9221-46de-8468-3ffce19b108c. internal/push implements the notify push-channel sender over SherClockHolmes/webpush-go: sends {title,body,url,tag} with TTL 12h to every subscription, records last_success_at, increments failure_count, deletes 404/410 subscriptions, and reports sent when at least one device succeeded (no subscriptions = sent with a note). See the task done-condition and the developer report on the PR.
orchestrator-agent added 1 commit 2026-10-09 13:19:25 -04:00
Add the Web Push sender for the push channel (Feature 19)
CI / ci (push) Successful in 5m23s
Details
CI / ci (pull_request) Successful in 5m25s
Details
8fe68659bd 
push.Sender implements notify.Sender for the "push" channel with
webpush-go and the VAPID key pair: it sends {title, body, url, tag} to
every stored subscription with a TTL of 12 hours, one request each.
Per subscription, an accepted notification records last_success_at, any
failure increments failure_count, and a 404 or 410 deletes the
subscription. Send succeeds when one device accepted it or when there
are no subscriptions (logged as nothing to send); otherwise it returns
an error so the outbox retries. Errors and logs name subscriptions by
id; a transport *url.Error is unwrapped so the endpoint is never quoted.

A mailto: VAPID subject is passed to webpush-go as its bare address,
since webpush-go prefixes mailto: itself.

The server registers the sender with the notify service.

Maestro task 32a1a4ad-9221-46de-8468-3ffce19b108c.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit d5ab945ee7 into feature/bbd91ead-1e2b-48fb-b577-fa0a3faf5842-notifications-web-push-and-google-chat 2026-10-09 13:45:21 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#164