Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

notify package and durable outbox worker (Feature 19) #161

Merged
approver_agent merged 2 commits from task/notify-outbox_addeb256-a4d4-4acf-8acd-6b6778d967ee into feature/bbd91ead-1e2b-48fb-b577-fa0a3faf5842-notifications-web-push-and-google-chat 2026-10-09 13:05:39 -04:00
Conversation 2 Commits 2 Files Changed 7
+1574 -5
orchestrator-agent commented 2026-10-09 11:41:48 -04:00
Member
Copy Link
Copy Source

Maestro task addeb256-a4d4-4acf-8acd-6b6778d967ee. internal/notify Emit plus the durable outbox worker with channel senders and retry backoff. See the task done-condition and the developer report on the PR.

Maestro task addeb256-a4d4-4acf-8acd-6b6778d967ee. internal/notify Emit plus the durable outbox worker with channel senders and retry backoff. See the task done-condition and the developer report on the PR.
orchestrator-agent added 1 commit 2026-10-09 11:41:49 -04:00
Add notify package and durable notification outbox worker (Feature 19)
CI / ci (push) Successful in 5m54s
Details
CI / ci (pull_request) Successful in 5m30s
Details
615969cff2 
Emit(ctx, Event) is the single decision point for who is told what: it
reads the event type's notification_prefs row and stores one pending
notification_outbox row per enabled channel, keyed by (event_key, channel)
with ON CONFLICT DO NOTHING, so a duplicate key never adds or resets a row.

The worker, started and stopped by cmd/server with the job runner, leases
due rows with a conditional update, delivers them through the Sender
registered for their channel, and marks them sent, or retries with a
backoff of 1 minute doubling to 1 hour until 24 hours after creation,
then marks them failed with last_error. A channel with no registered
sender fails its rows with an explicit error.

Maestro task addeb256-a4d4-4acf-8acd-6b6778d967ee.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent requested changes 2026-10-09 11:46:40 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
overseer added 1 commit 2026-10-09 12:27:46 -04:00
Fail overdue notifications before sending them (N-01)
CI / ci (push) Successful in 6m18s
Details
CI / ci (pull_request) Successful in 6m4s
Details
101498185e 
The worker checked the 24-hour give-up deadline only after Send failed, so
an overdue row whose delivery succeeded was marked sent and a stale
notification reached the household. Check the deadline before Send: a row
claimed 24 hours or more after its creation is marked failed, with the
reason and any previous error in last_error, and the sender is never
called. A delivery failing before the deadline still retries with the same
backoff.

Tests cover a succeeding and a failing sender at exactly 24 hours and
after, a row just under the deadline still being sent, and the retry run
now ending with a failure at the deadline instead of a 30th attempt.

Task: addeb256-a4d4-4acf-8acd-6b6778d967ee

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 104396da55 into feature/bbd91ead-1e2b-48fb-b577-fa0a3faf5842-notifications-web-push-and-google-chat 2026-10-09 13:05:39 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#161