Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature 14: Weekly Plan Builder #121

Merged
approver_agent merged 8 commits from feature/ca2a118d-0beb-49f9-b2ef-d5ed0ac1fa2a-weekly-plan-builder into dev 2026-10-07 16:53:24 -04:00
Conversation 2 Commits 8 Files Changed 70
+9332 -114
orchestrator-agent commented 2026-10-07 15:54:40 -04:00
Member
Copy Link
Copy Source

Feature 14 — Weekly Plan Builder

Integration pull request: feature/ca2a118d-0beb-49f9-b2ef-d5ed0ac1fa2a-weekly-plan-builder -> dev.

The AI-drafted weekly dinner schedule the household adjusts, mixing Regulars and Quest-log picks — one dinner per day Monday to Sunday (requirements §7; mobile mock 1f, tablet 2c, desktop 2d).

Tasks (all seven merged, each independently reviewed at its exact head)

Task Maestro PR Reviewed head
draft_week skill 7ab59240 #113 c9baf08
Plan service and API ea48e650 #114 1f548c9
Rotation check: tried dinners and keep/drop a1887d1c #116 cca6a82
Mobile draft board (1f) 4bb14d54 #117 870f346
Mobile swap sheet f231813c #118 2164e24
Tablet and desktop plan manager (2c, 2d) 4657cba1 #119 8d46b58
Drag-and-drop and keyboard swapping 5c2842a8 #120 9e0c20a

What the feature delivers

  • draft_week skill v1 (prompt layering, one repair turn, validators: 7 consecutive Mon–Sun dates from the pool, no repeats) and the plan service/API: GET /plans/{weekStart}, POST /plans/{weekStart}/draft (async, confirm required over a synced/changed plan), PUT /plans/{weekStart}/days/{date}.
  • Rotation check per D-021: MarkTried + GET /api/v1/rotation-reviews + POST /api/v1/dinners/{id}/rotation-review (keep -> regular, drop -> archived with an immutable name for dedupe, not_made -> quest log, 404/409 distinctions). Nothing promotes a dinner to Regular automatically.
  • The mobile Draft board (mock 1f) with the assistant bubble, NEW highlighting, crock-pot "Start by", "+ Rebuild week" with confirm, and the empty state; the mobile swap sheet with the Quest log / Regulars control and optimistic swap; the tablet/desktop plan manager (2c/2d) with the 7-column grid, the desktop Quest log panel, the tablet chip strip, method-aware durations and the relative sync time; and pointer + keyboard swapping.

Integration checks at the feature head 955613941fc9f8469ba4e7b02367cc35bd67840d (7 commits ahead of dev, 0 behind)

  • gofmt -l . — empty
  • go vet ./... — clean
  • go test -race -count=1 ./... — 25 packages ok, 0 failures
  • CGO_ENABLED=0 go build ./... — ok
  • make sqlc-check SQLC=$(go env GOPATH)/bin/sqlc — no drift in internal/db
  • cd web && npm run typecheck — PASS
  • cd web && npm test — PASS, 45 files / 761 tests
  • cd web && npm run build — PASS (colour lint + dist-font check)
  • make test, make build — PASS
  • docker build . — PASS

The branch already contains all of dev, so no dev merge was needed.

Notes

  • Two non-blocking findings and one further LOW from task reviews are dispositioned, not waived, and tracked as Maestro task d21e4a83-9ae4-4944-9621-a10db9fad0b9 in Feature 22: pruning settled swap entries from the mutation cache; a narrow identical-field rollback edge; and strict RFC 3339 parsing for syncedAt.
  • "Shopping list" and "Push to Calendar" ship disabled with tooltips because Features 17 and 16 have no endpoints yet; "Rebuild week" works.
## Feature 14 — Weekly Plan Builder Integration pull request: `feature/ca2a118d-0beb-49f9-b2ef-d5ed0ac1fa2a-weekly-plan-builder` -> `dev`. The AI-drafted weekly dinner schedule the household adjusts, mixing Regulars and Quest-log picks — one dinner per day Monday to Sunday (requirements §7; mobile mock 1f, tablet 2c, desktop 2d). ## Tasks (all seven merged, each independently reviewed at its exact head) | Task | Maestro | PR | Reviewed head | | --- | --- | --- | --- | | draft_week skill | 7ab59240 | #113 | c9baf08 | | Plan service and API | ea48e650 | #114 | 1f548c9 | | Rotation check: tried dinners and keep/drop | a1887d1c | #116 | cca6a82 | | Mobile draft board (1f) | 4bb14d54 | #117 | 870f346 | | Mobile swap sheet | f231813c | #118 | 2164e24 | | Tablet and desktop plan manager (2c, 2d) | 4657cba1 | #119 | 8d46b58 | | Drag-and-drop and keyboard swapping | 5c2842a8 | #120 | 9e0c20a | ## What the feature delivers - `draft_week` skill v1 (prompt layering, one repair turn, validators: 7 consecutive Mon–Sun dates from the pool, no repeats) and the plan service/API: `GET /plans/{weekStart}`, `POST /plans/{weekStart}/draft` (async, `confirm` required over a synced/changed plan), `PUT /plans/{weekStart}/days/{date}`. - Rotation check per D-021: `MarkTried` + `GET /api/v1/rotation-reviews` + `POST /api/v1/dinners/{id}/rotation-review` (keep -> regular, drop -> archived with an immutable name for dedupe, not_made -> quest log, 404/409 distinctions). Nothing promotes a dinner to Regular automatically. - The mobile Draft board (mock 1f) with the assistant bubble, NEW highlighting, crock-pot "Start by", "+ Rebuild week" with confirm, and the empty state; the mobile swap sheet with the Quest log / Regulars control and optimistic swap; the tablet/desktop plan manager (2c/2d) with the 7-column grid, the desktop Quest log panel, the tablet chip strip, method-aware durations and the relative sync time; and pointer + keyboard swapping. ## Integration checks at the feature head `955613941fc9f8469ba4e7b02367cc35bd67840d` (7 commits ahead of `dev`, 0 behind) - `gofmt -l .` — empty - `go vet ./...` — clean - `go test -race -count=1 ./...` — 25 packages ok, 0 failures - `CGO_ENABLED=0 go build ./...` — ok - `make sqlc-check SQLC=$(go env GOPATH)/bin/sqlc` — no drift in `internal/db` - `cd web && npm run typecheck` — PASS - `cd web && npm test` — PASS, 45 files / 761 tests - `cd web && npm run build` — PASS (colour lint + dist-font check) - `make test`, `make build` — PASS - `docker build .` — PASS The branch already contains all of `dev`, so no `dev` merge was needed. ## Notes - Two non-blocking findings and one further LOW from task reviews are dispositioned, not waived, and tracked as Maestro task `d21e4a83-9ae4-4944-9621-a10db9fad0b9` in Feature 22: pruning settled swap entries from the mutation cache; a narrow identical-field rollback edge; and strict RFC 3339 parsing for `syncedAt`. - "Shopping list" and "Push to Calendar" ship disabled with tooltips because Features 17 and 16 have no endpoints yet; "Rebuild week" works.
orchestrator-agent added 7 commits 2026-10-07 15:54:40 -04:00
draft_week skill v1 (#113)
CI / ci (push) Successful in 2m46s
Details
09456c48a2 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Plan service and weekly plan API (#114)
CI / ci (push) Successful in 3m10s
Details
2ed5f69783 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Rotation check: tried dinners and keep/drop decisions (#116)
CI / ci (push) Failing after 5s
Details
0a47b26af6 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Mobile draft board (1f) (#117)
CI / ci (push) Successful in 3m21s
Details
9b9421bb58 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Mobile swap sheet (Feature 14) (#118)
CI / ci (push) Successful in 3m13s
Details
3aef21922b 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Tablet and desktop plan manager (2c, 2d) (#119)
CI / ci (push) Successful in 3m18s
Details
dba4b93280 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
Drag-and-drop and keyboard swapping (Feature 14) (#120)
CI / ci (pull_request) Successful in 3m24s
Details
CI / ci (push) Successful in 3m28s
Details
955613941f 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
review_agent requested changes 2026-10-07 15:57:40 -04:00
Dismissed
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.

Independent Codex gpt-6-sol review: CHANGES_REQUIRED for this exact commit.
approver_agent added 1 commit 2026-10-07 16:30:05 -04:00
Feature 14 integration fix: revalidate the draft pool, refuse duplicate week dinners, refresh the Quest log (#122)
CI / ci (push) Successful in 3m43s
Details
CI / ci (pull_request) Successful in 3m55s
Details
76a2b611c8 
Co-authored-by: orchestrator-agent <20+orchestrator-agent@code.cubecraftcreations.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent Codex gpt-6-sol review: APPROVED for this exact commit.

Independent Codex gpt-6-sol review: APPROVED for this exact commit.
approver_agent merged commit 1862f450db into dev 2026-10-07 16:53:24 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#121