Feature 13 integration fix: deck error surfacing, active-batch tracking, modal key scope, three-card deck #111

Merged

approver_agent merged 2 commits from task/feature13-integration-fix_2b9d4e77-0c1a-4a1b-9f0e-1a2b3c4d5e6f into feature/e3a8e4ea-8dcb-49e8-878f-552a6af109cb-discover-side-quest-suggestions

2026-10-07 05:20:11 -04:00

Author	SHA1	Message	Date
dev_agentandClaude Opus 5.5	71060515bd	Fail orphaned suggestion batches before reporting the deck's active batch CI / ci (push) Successful in 3m5s Details CI / ci (pull_request) Successful in 2m45s Details Deck returned a pending or running batch's job id without checking that the job was still queued or running, so after a restart failed the job the page polled a dead job as the active batch. Deck and startBatch now share activeBatch, which runs FailOrphanedSuggestionBatches before reading the active batch; Deck therefore uses a write transaction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-07 05:13:48 -04:00
dev_agentandClaude Opus 5.5	af58caac94	Surface replenish failures, follow the active batch, scope deck keys, keep three deck depths CI / ci (push) Successful in 3m2s Details CI / ci (pull_request) Successful in 2m44s Details Fixes the Feature 13 review findings on the Discover deck (Maestro task 4fc551f0-3c11-4c15-b638-f2c08a28eb29): - F13-01: a batch failure (start, poll or job) is shown with its Retry whatever the deck has, so a replenish that fails while cards remain is no longer silent until the deck runs out. - F13-02: GET /api/v1/suggestions/deck reports the batch pending or running (active_batch, read in the deck's snapshot), and a decision that calls for a replenish returns the job of the batch it started or joined. The page follows a newly reported active batch, so a reopened page or a second session shows skeleton cards while the batch runs instead of "All caught up". - F13-03: ← / → leave the deck alone while it is inert behind a modal (the Quest log sheet or its confirmation). - F13-04: a one- or two-card deck keeps all three depths: skeleton cards stand in for the missing ones while a batch finds more Side quests, blank stack-edge cards while none is coming. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-07 05:04:20 -04:00

Author

SHA1

Message

Date

dev_agentandClaude Opus 5.5

71060515bd

Fail orphaned suggestion batches before reporting the deck's active batch

CI / ci (push) Successful in 3m5s

Details

CI / ci (pull_request) Successful in 2m45s

Details

Deck returned a pending or running batch's job id without checking that
the job was still queued or running, so after a restart failed the job
the page polled a dead job as the active batch. Deck and startBatch now
share activeBatch, which runs FailOrphanedSuggestionBatches before
reading the active batch; Deck therefore uses a write transaction.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-07 05:13:48 -04:00

dev_agentandClaude Opus 5.5

af58caac94

Surface replenish failures, follow the active batch, scope deck keys, keep three deck depths

CI / ci (push) Successful in 3m2s

Details

CI / ci (pull_request) Successful in 2m44s

Details

Fixes the Feature 13 review findings on the Discover deck (Maestro task
4fc551f0-3c11-4c15-b638-f2c08a28eb29):

- F13-01: a batch failure (start, poll or job) is shown with its Retry
  whatever the deck has, so a replenish that fails while cards remain is
  no longer silent until the deck runs out.
- F13-02: GET /api/v1/suggestions/deck reports the batch pending or
  running (active_batch, read in the deck's snapshot), and a decision
  that calls for a replenish returns the job of the batch it started or
  joined. The page follows a newly reported active batch, so a reopened
  page or a second session shows skeleton cards while the batch runs
  instead of "All caught up".
- F13-03: ← / → leave the deck alone while it is inert behind a modal
  (the Quest log sheet or its confirmation).
- F13-04: a one- or two-card deck keeps all three depths: skeleton cards
  stand in for the missing ones while a batch finds more Side quests,
  blank stack-edge cards while none is coming.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-07 05:04:20 -04:00