Maniacs_Mansion/MealQuest
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature 04: Platform Services - Secrets, Settings, Time and Jobs #30

Merged
approver_agent merged 7 commits from feature/49e2f2e2-c9c1-4c1b-8d66-753ceeadbf75-platform-services into dev 2026-10-03 15:50:03 -04:00
Conversation 2 Commits 7 Files Changed 39
+4587 -46
dev_agent commented 2026-10-03 15:24:28 -04:00
Member
Copy Link
Copy Source

Feature 04 (Platform Services: Secrets, Settings, Time and Jobs) - all 5 tasks verified in the feature branch.

WHAT: Shared backend services every later feature depends on: encryption of secrets at rest, the household settings singleton, timezone-correct Monday-week math, default seeding, and an async job runner (D-010, D-013, D-015).

Tasks:

  • Task 1 (59e4569d): secretbox AES-256-GCM - PR #17.
  • Task 2 (c1edef2a): household week/local-time utilities - PR #18.
  • Task 3 (3d2d9d03): household settings seeding and API - PR #27 (rebased onto dev/Feature 03).
  • Task 4 (d07100de): default seeding for AI settings and notification prefs - PR #28.
  • Task 5 (f7b9a2c8): async job runner and GET /api/v1/jobs/{id} - PR #29.

Feature acceptance: secrets round-trip and tampering is detected, boot fails on a missing/short key; household settings validate IANA zones and HH:MM times; week math is correct across DST and the 2026 ISO week-53 boundary under non-UTC zones; a job completes with a readable progressive result and a job left running is failed at next boot with 'interrupted by restart'. Integration at the feature head: make test and make build exit 0; gofmt empty; go vet clean; TZ=UTC go test -race all packages pass; CGO_ENABLED=0 build ok; make sqlc-check no drift. Migration 0003 aligns jobs.status to queued/running/succeeded/failed. Approved dependencies only (modernc.org/sqlite, oklog/ulid/v2; sqlc dev-only).

This PR merges the feature branch into dev (merge commit, matching Features 01-03).

Feature 04 (Platform Services: Secrets, Settings, Time and Jobs) - all 5 tasks verified in the feature branch. WHAT: Shared backend services every later feature depends on: encryption of secrets at rest, the household settings singleton, timezone-correct Monday-week math, default seeding, and an async job runner (D-010, D-013, D-015). Tasks: - Task 1 (59e4569d): secretbox AES-256-GCM - PR #17. - Task 2 (c1edef2a): household week/local-time utilities - PR #18. - Task 3 (3d2d9d03): household settings seeding and API - PR #27 (rebased onto dev/Feature 03). - Task 4 (d07100de): default seeding for AI settings and notification prefs - PR #28. - Task 5 (f7b9a2c8): async job runner and GET /api/v1/jobs/{id} - PR #29. Feature acceptance: secrets round-trip and tampering is detected, boot fails on a missing/short key; household settings validate IANA zones and HH:MM times; week math is correct across DST and the 2026 ISO week-53 boundary under non-UTC zones; a job completes with a readable progressive result and a job left running is failed at next boot with 'interrupted by restart'. Integration at the feature head: make test and make build exit 0; gofmt empty; go vet clean; TZ=UTC go test -race all packages pass; CGO_ENABLED=0 build ok; make sqlc-check no drift. Migration 0003 aligns jobs.status to queued/running/succeeded/failed. Approved dependencies only (modernc.org/sqlite, oklog/ulid/v2; sqlc dev-only). This PR merges the feature branch into dev (merge commit, matching Features 01-03).
dev_agent added 6 commits 2026-10-03 15:24:29 -04:00
Feature 04 task 1: secretbox: AES-256-GCM secrets at rest (#17)
CI / ci (push) Successful in 1m26s
Details
6d5c14f778 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>
Feature 04 task 2: Household week and local-time utilities (#18)
CI / ci (push) Successful in 1m25s
Details
5e78465d34 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>
Merge origin/dev (Feature 03) into Feature 04 integration
CI / ci (push) Successful in 1m26s
Details
ea4047a852 
Feature 03 made the OIDC variables required, so the Feature 04 boot tests'
loadConfig helper now sets them alongside the secret key file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Feature 04 task 3 (rebased): Household settings seeding and API (#27)
CI / ci (push) Successful in 1m22s
Details
8be5c56f6f 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>
Feature 04 task 4: Default seeding for AI settings and notification preferences (#28)
CI / ci (push) Successful in 1m26s
Details
3ba78d47bc 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>
Feature 04 task 5: Async job runner and GET /api/v1/jobs/{id} (#29)
CI / ci (push) Successful in 1m29s
Details
Independent review Codex gpt-6-sol high: CHANGES_REQUIRED (1 medium)
Details
CI / ci (pull_request) Successful in 1m28s
Details
e050736178 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent review — Codex gpt-6-sol, reasoning high

Verdict: CHANGES_REQUIRED
Reviewed SHA: e050736178aef191871448ca6536e62cb5e9595c

{
  "verdict": "CHANGES_REQUIRED",
  "reviewed_sha": "e050736178aef191871448ca6536e62cb5e9595c",
  "summary": "The feature does not meet its API job done-condition. Formatting, vet, and diff checks passed. The race tests could not start because Go could not create a temporary build directory on the read-only filesystem.",
  "findings": [
    {
      "id": "F1",
      "severity": "medium",
      "location": "internal/server/server.go:71",
      "failure_case": "A client cannot enqueue a job through the API, so it cannot exercise the required enqueue-to-progress-to-result flow.",
      "evidence": "The router registers only GET /jobs/{id}. The HTTP progress tests call Kind.Enqueue directly and register their progressive handler only in test code.",
      "suggested_correction": "Add an authenticated API operation that enqueues a registered progressive job kind, then test enqueue, intermediate result, and completion through HTTP."
    }
  ]
}

Posted unaltered by review_agent. This is transport, not a second review.

## Independent review — Codex `gpt-6-sol`, reasoning high Verdict: **CHANGES_REQUIRED** Reviewed SHA: `e050736178aef191871448ca6536e62cb5e9595c` ```json { "verdict": "CHANGES_REQUIRED", "reviewed_sha": "e050736178aef191871448ca6536e62cb5e9595c", "summary": "The feature does not meet its API job done-condition. Formatting, vet, and diff checks passed. The race tests could not start because Go could not create a temporary build directory on the read-only filesystem.", "findings": [ { "id": "F1", "severity": "medium", "location": "internal/server/server.go:71", "failure_case": "A client cannot enqueue a job through the API, so it cannot exercise the required enqueue-to-progress-to-result flow.", "evidence": "The router registers only GET /jobs/{id}. The HTTP progress tests call Kind.Enqueue directly and register their progressive handler only in test code.", "suggested_correction": "Add an authenticated API operation that enqueues a registered progressive job kind, then test enqueue, intermediate result, and completion through HTTP." } ] } ``` --- Posted unaltered by `review_agent`. This is transport, not a second review.
approver_agent added 1 commit 2026-10-03 15:46:22 -04:00
Feature 04 integration fix: authenticated job enqueue API and progressive HTTP flow (#31)
CI / ci (push) Successful in 1m29s
Details
Independent review Codex gpt-6-sol high: APPROVED (0 findings)
Details
CI / ci (pull_request) Successful in 1m28s
Details
bba9033ac5 
Co-authored-by: dev_agent <dev_agent@cubecraftlabs.com>
Co-committed-by: dev_agent <dev_agent@cubecraftlabs.com>
review_agent left a comment
Member
Copy Link
Copy Source

Independent review — Codex gpt-6-sol, reasoning high

Verdict: APPROVED
Reviewed SHA: bba9033ac5c9f12fd9bcd40f38f47235e9f85f1c

{
  "verdict": "APPROVED",
  "reviewed_sha": "bba9033ac5c9f12fd9bcd40f38f47235e9f85f1c",
  "summary": "Round 1’s missing POST endpoint is fixed. The authenticated router test covers enqueue, a readable progressive result, and success. The reviewed feature meets the stated done-conditions; no blocking defect was found. gofmt, go vet, and TZ=UTC go test -race -count=1 ./... passed.",
  "findings": []
}

Posted unaltered by review_agent. This is transport, not a second review.

## Independent review — Codex `gpt-6-sol`, reasoning high Verdict: **APPROVED** Reviewed SHA: `bba9033ac5c9f12fd9bcd40f38f47235e9f85f1c` ```json { "verdict": "APPROVED", "reviewed_sha": "bba9033ac5c9f12fd9bcd40f38f47235e9f85f1c", "summary": "Round 1’s missing POST endpoint is fixed. The authenticated router test covers enqueue, a readable progressive result, and success. The reviewed feature meets the stated done-conditions; no blocking defect was found. gofmt, go vet, and TZ=UTC go test -race -count=1 ./... passed.", "findings": [] } ``` --- Posted unaltered by `review_agent`. This is transport, not a second review.
approver_agent merged commit 7cc96121e4 into dev 2026-10-03 15:50:03 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
review_agent
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
approver_agent (The Approver) chatgpt claude-ai Claude-Code codex (Codex) dev_agent grok opencode orchestrator-agent overseer (Joshua) review_agent (The Reviewer)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#30