Feature 04 task 4: Default seeding for AI settings and notification preferences #28

Member

Implements Feature 04 task 4 (d07100de). Done-condition: first boot seeds ai_settings (provider anthropic, empty base_url/model/key, temperature 0.7, the embedded default persona prompt used later by Reset) and notification_prefs for all five events (push on for all; chat on for plan_ready/list_ready only); re-boots never overwrite existing rows; tests cover seeding values and no overwrite; quality floor passes.

Evidence (developer-run): gofmt empty; go vet clean; TZ=UTC go test -race all 11 packages, 485/485 tests pass; CGO_ENABLED=0 build ok. Adds household.DefaultPersonaPrompt and SeedAISettings/SeedNotificationPrefs, wired into cmd/server seedDefaults at boot.

Base: feature/49e2f2e2-... (8be5c56).

Implements Feature 04 task 4 (d07100de). Done-condition: first boot seeds ai_settings (provider anthropic, empty base_url/model/key, temperature 0.7, the embedded default persona prompt used later by Reset) and notification_prefs for all five events (push on for all; chat on for plan_ready/list_ready only); re-boots never overwrite existing rows; tests cover seeding values and no overwrite; quality floor passes. Evidence (developer-run): gofmt empty; go vet clean; TZ=UTC go test -race all 11 packages, 485/485 tests pass; CGO_ENABLED=0 build ok. Adds household.DefaultPersonaPrompt and SeedAISettings/SeedNotificationPrefs, wired into cmd/server seedDefaults at boot. Base: feature/49e2f2e2-... (8be5c56).
dev_agent added 1 commit 2026-10-03 14:55:26 -04:00
Seed default AI settings and notification preferences at boot
CI / ci (pull_request) Successful in 1m24s
Independent review Codex gpt-6-sol high: APPROVED (0 findings)
CI / ci (push) Successful in 1m26s
989d13b69c
On first boot create the ai_settings row (provider anthropic, empty base
URL, model and key, temperature 0.7, system prompt DefaultPersonaPrompt
from CTXD PROMPTS.MD §4) and a notification_prefs row per event (push on
for all five, chat on for plan_ready and list_ready only). Existing rows
are never changed; a missing event row is seeded on its own.

cmd/server seeds household settings, AI settings and notification
preferences through seedDefaults; any failure stops the boot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member

Independent review — Codex gpt-6-sol, reasoning high

Verdict: APPROVED
Reviewed SHA: 989d13b69c4f00b1f2d94dc595a645a13db195a8

{
  "verdict": "APPROVED",
  "reviewed_sha": "989d13b69c4f00b1f2d94dc595a645a13db195a8",
  "summary": "The seed values, persona text, boot wiring, and no-overwrite behavior match the done-condition. Tests use independent expected values, and the diff adds no dependency or unrelated change. gofmt and go vet passed. The race test could not start because the read-only environment prevented Go from creating its temporary build directory.",
  "findings": []
}

Posted unaltered by review_agent. This is transport, not a second review.

## Independent review — Codex `gpt-6-sol`, reasoning high Verdict: **APPROVED** Reviewed SHA: `989d13b69c4f00b1f2d94dc595a645a13db195a8` ```json { "verdict": "APPROVED", "reviewed_sha": "989d13b69c4f00b1f2d94dc595a645a13db195a8", "summary": "The seed values, persona text, boot wiring, and no-overwrite behavior match the done-condition. Tests use independent expected values, and the diff adds no dependency or unrelated change. gofmt and go vet passed. The race test could not start because the read-only environment prevented Go from creating its temporary build directory.", "findings": [] } ``` --- Posted unaltered by `review_agent`. This is transport, not a second review.
approver_agent merged commit 3ba78d47bc into feature/49e2f2e2-c9c1-4c1b-8d66-753ceeadbf75-platform-services 2026-10-03 14:58:33 -04:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/MealQuest#28