overseer
77fdd2531c
P2.1: Point test_presence.py ISO-week scan at core.presence (the real model since task 510c1f78); the integration's presence.py is now a re-export shim, so scanning it was vacuous. P2.2: Add direct core-builder unit tests to test_events.py — exact payload key sets for completed/uncompleted/day-complete events, was_on_time threading (True/False/None), event ordering (completed fires before day-complete on the bus), and the four day-complete outcomes (zero-quest day, non-today instance, partial day, fully-cleared today). Add a shim timezone test that sets hass.config.time_zone to a zone whose local date differs from UTC and asserts the day-complete rule uses that local date. P3.1: Split build_quest_completed_events into build_quest_completed_event (single event, no day-complete state) and build_child_day_complete_event (separate, returns the day-complete event or None). The shim fires nestquest_quest_completed BEFORE it reads the HA-local today and evaluates the day-complete rule, restoring the pre-extraction ordering so a failure in the day-complete DB reads or the ZoneInfo lookup cannot suppress the completed event. Payloads and the day-complete rule are identical. P3.2: test_startup_db.py glob -> rglob so core/ is scanned by the 'never unlinks or truncates DB files' guardrail (non-recursive glob skipped the extracted core package). P3.3: RELEASE_NOTES.md notes the children and admin_allowlist loggers moved to .core.children / .core.admin_allowlist (parent logger still catches them). P3.4: Refresh the stale test_core_isolation.py docstring to cover the whole core package (storage-layer task d0b691d8 + engines/business- layer task 510c1f78). uv run pytest -q = 1507 passed (baseline 1497 + 10 new).
80 lines
3.0 KiB
Python
80 lines
3.0 KiB
Python
"""Re-export / HA wiring of :mod:`custom_components.nestquest.core.events` for the integration package.
|
|
|
|
The transition-event payload construction lives in
|
|
:mod:`custom_components.nestquest.core.events` (extracted in
|
|
task 510c1f78) and is HA-free: it builds and RETURNS the events. This
|
|
shim keeps the integration's old ``fire_quest_completed`` /
|
|
``fire_quest_uncompleted`` API (the complete/uncomplete service
|
|
handlers call them with ``hass``), reads the HA-local timezone from
|
|
``hass.config.time_zone`` to derive ``today``, asks the core builder
|
|
for the events, and fires each on ``hass.bus`` with the documented
|
|
payloads. The four blueprints keep working with identical payloads.
|
|
|
|
The completed event is fired BEFORE the day-complete rule evaluates:
|
|
``fire_quest_completed`` asks
|
|
:func:`build_quest_completed_event` for the completed event and fires
|
|
it immediately, THEN reads the HA-local ``today``, asks
|
|
:func:`build_child_day_complete_event` for the day-complete event, and
|
|
fires it (if any) afterwards. This restores the pre-extraction
|
|
ordering — a failure in the day-complete DB reads or the ZoneInfo
|
|
lookup cannot suppress the completed event.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import datetime
|
|
from zoneinfo import ZoneInfo
|
|
|
|
from .core.db import NestQuestDatabase
|
|
from .core.events import (
|
|
build_child_day_complete_event,
|
|
build_quest_completed_event,
|
|
build_quest_uncompleted_events,
|
|
)
|
|
|
|
__all__ = ["fire_quest_completed", "fire_quest_uncompleted"]
|
|
|
|
|
|
async def fire_quest_completed(
|
|
hass,
|
|
database: NestQuestDatabase,
|
|
instance_id: int,
|
|
*,
|
|
was_on_time: bool | None,
|
|
) -> None:
|
|
"""Fire ``nestquest_quest_completed`` and, when the completion
|
|
cleared the child's whole day, ``nestquest_child_day_complete``.
|
|
|
|
Thin HA wiring over the HA-free
|
|
:func:`custom_components.nestquest.core.events.build_quest_completed_event`
|
|
and
|
|
:func:`build_child_day_complete_event`: the completed event is
|
|
built and fired FIRST (so a failure in the day-complete DB reads
|
|
or the HA-local ``today`` lookup cannot suppress it), then the
|
|
HA-local ``today`` (the day-complete rule's input) is read from
|
|
``hass.config.time_zone`` and the day-complete builder is asked
|
|
whether the child's whole day cleared. Identical payloads and
|
|
day-complete rule to the pre-extraction implementation.
|
|
"""
|
|
completed = await build_quest_completed_event(
|
|
database,
|
|
instance_id,
|
|
was_on_time=was_on_time,
|
|
)
|
|
hass.bus.async_fire(*completed)
|
|
|
|
today = datetime.datetime.now(ZoneInfo(hass.config.time_zone)).date()
|
|
day_complete = await build_child_day_complete_event(
|
|
database, completed[1], today=today
|
|
)
|
|
if day_complete is not None:
|
|
hass.bus.async_fire(*day_complete)
|
|
|
|
|
|
async def fire_quest_uncompleted(
|
|
hass, database: NestQuestDatabase, instance_id: int
|
|
) -> None:
|
|
"""Fire ``nestquest_quest_uncompleted`` for an actual reversal."""
|
|
events = await build_quest_uncompleted_events(database, instance_id)
|
|
for event_type, payload in events:
|
|
hass.bus.async_fire(event_type, payload)
|