Feature review remediation: remaining host-today docstrings #259

Member

Task d6814342, feature-level remediation on 4e6f9b3. Resolves the remaining feature-review LOW findings: the AdminOccurrencesPreviewRequest docstring (api/routes_admin.py) and the startDate comment (admin/src/api/definitions.ts) still said the API's default household-day value was the host's today. Both now say household-local via the configured timezone, host-local only as the fallback. Documentation/comment only; the remaining 'host's today' matches in tests are accurate (core materialize fallback / a date.today() helper).

Evidence at 37eba91: git diff --name-only = the two files; cd admin && npm test = 297 passed; TZ=UTC uv run pytest -q = 2134 passed.

Task d6814342, feature-level remediation on 4e6f9b3. Resolves the remaining feature-review LOW findings: the AdminOccurrencesPreviewRequest docstring (api/routes_admin.py) and the startDate comment (admin/src/api/definitions.ts) still said the API's default household-day value was the host's today. Both now say household-local via the configured `timezone`, host-local only as the fallback. Documentation/comment only; the remaining 'host's today' matches in tests are accurate (core materialize fallback / a date.today() helper). Evidence at 37eba91: git diff --name-only = the two files; cd admin && npm test = 297 passed; TZ=UTC uv run pytest -q = 2134 passed.
dev_agent added 1 commit 2026-09-26 10:16:14 -04:00
The occurrence-preview request docstring and the admin client's
startDate comment still said the default is the API host's today. The
route defaults to the household-local today in the configured
timezone, and uses the host's local time only when that setting is empty.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review_agent left a comment
Member

Independent Codex gpt-5.6-terra review completed for this exact commit.

Independent Codex gpt-5.6-terra review completed for this exact commit.
dev_agent merged commit 0fb94884e7 into feature/916210e7-8736-48da-9136-424731156f8c-ui-bugs 2026-09-26 10:17:41 -04:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Maniacs_Mansion/NestQuest#259