From 7ebd893823b48a0a8546513745c6689f92fdec55 Mon Sep 17 00:00:00 2001 From: Joshua King Date: Tue, 15 Sep 2026 17:23:32 -0400 Subject: [PATCH] Test fix: malformed owner_ids validated before the seed's early return The seed validates candidates only when the allowlist is empty; the test's successful first seed masked the malformed case. The rejection now runs first. Suite: 908 passed. --- tests/test_admin_allowlist.py | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/tests/test_admin_allowlist.py b/tests/test_admin_allowlist.py index c371815..7b4def1 100644 --- a/tests/test_admin_allowlist.py +++ b/tests/test_admin_allowlist.py @@ -354,14 +354,9 @@ async def test_setup_owner_fallback_not_used_when_context_present( def test_seed_owner_ids_argument(tmp_path) -> None: async def _body(database): - seeded = await seed_setup_admin( - database, - stored_admin_ids=None, - context_user_id=None, - owner_ids=["owner-1"], - ) - assert seeded == ["owner-1"] - # Malformed owner lists are rejected like any other candidate. + # Malformed owner lists are rejected like any other candidate — + # while the allowlist is still empty, so the seed proceeds far + # enough to validate. with pytest.raises(ValueError): await seed_setup_admin( database, @@ -369,6 +364,14 @@ def test_seed_owner_ids_argument(tmp_path) -> None: context_user_id=None, owner_ids=[7], ) + assert await list_admin_ids(database) == [] + seeded = await seed_setup_admin( + database, + stored_admin_ids=None, + context_user_id=None, + owner_ids=["owner-1"], + ) + assert seeded == ["owner-1"] return seeded _with_db(tmp_path, "seed-owner-arg.db")(_body)